Update controller-gen to 0.9.2 #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/S
voelzmo
changed the title
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
mwielgus
reviewed
Sep 14, 2022
voelzmo
changed the title
jbartosik
reviewed
Sep 26, 2022
| @@ -203,19 +203,13 @@ spec: | |||
| type: object | |||
| served: true | |||
| storage: false | |||
| status: | |||
There was a problem hiding this comment.
Do you know why regenerating deletes this?
There was a problem hiding this comment.
I think this was accepted as a bug some time ago: kubernetes-sigs/controller-tools#456 and fixed from version 0.9.0 with kubernetes-sigs/controller-tools#630
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
…-gen Update controller-gen to 0.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
vertical-pod-autoscaler
What type of PR is this?
/kind cleanup
What this PR does / why we need it
Update controller-gen to 0.9.2 and install with
go install, asgo getdoesn't install binaries anymore with go1.18Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?