Bug fix for auto-resizer 1.8.1 not reading command arguments

[tesharp]

Cpu and memory arguments from command line are not read at all, leaving them empty. nannyConfigurationFromFlags sets default values to argument values. In loadNannyConfiguration it attempts to read from config, but if config is not set it just creates an empty configMapConfig. Since this is empty calling nannyconfigalpha.FillInDefaults_NannyConfiguration doesn't actually do anything as it compares the values against default values, so when all values are empty this does nothing. In the end function just returns empty values for everything and never uses command line arguments.

Starting container in acs-engine leads to these errors now:

ERROR: logging before flag.Parse: I0118 13:57:09.157760       1 pod_nanny.go:64] Invoked by [/pod_nanny --cpu=80m --extra-cpu=0.5m --memory=140Mi --extra-memory=4Mi --threshold=5 --deployment=heapster --container=heapster --poll-period=300000 --estimator=exponential]
ERROR: logging before flag.Parse: I0118 13:57:09.157850       1 pod_nanny.go:76] Watching namespace: kube-system, pod: heapster-548bd647cc-7fpgv, container: heapster.
ERROR: logging before flag.Parse: I0118 13:57:09.157856       1 pod_nanny.go:77] storage: MISSING, extra_storage: 0Gi
ERROR: logging before flag.Parse: I0118 13:57:09.159734       1 pod_nanny.go:162] Failed to read data from config file "MISSING/NannyConfiguration": open MISSING/NannyConfiguration: no such file or directory, using default parameters
ERROR: logging before flag.Parse: I0118 13:57:09.159804       1 pod_nanny.go:166]
ERROR: logging before flag.Parse: I0118 13:57:09.159917       1 pod_nanny.go:101] cpu: , extra_cpu: , memory: , extra_memory:
panic: cannot parse '': quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[MaciekPytel]

cc: @kawych @x13n

[kawych]

Please delete this line, it doesn't look helpful.

[tesharp]

Line 167?

[kawych]

Yes

[kawych]

I think we need to set:
configMapConfig = &nannyconfigalpha.NannyConfiguration{}
Otherwise configMapConfig will be nil and line 166 will fail.

[kawych]

/lgtm
Please squash commits

[richerve]

I'm seeing the same issue, even in 1.8.1

prometheus-operator/prometheus-operator#997

I didn't notice that this is not included in 1.8.1 but is a fix for that version. When is the new version going to be deployed?