Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atomic scale down option for node groups #5695

Merged
merged 10 commits into from
Jun 30, 2023
Merged

Add atomic scale down option for node groups #5695

merged 10 commits into from
Jun 30, 2023

Commits on Jun 27, 2023

  1. Move two util functions from actuator to delete_in_batch, where they … 

    …are more appropriate
    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1847875 View commit details
    Browse the repository at this point in the history

  2. Add support for atomic scale-down in node group options

    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    61b7958 View commit details
    Browse the repository at this point in the history

  3. Extract cropNodesToBudgets function out of actuator file

    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    292a517 View commit details
    Browse the repository at this point in the history

  4. Support atomic scale-down option for node groups

    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7e3e15b View commit details
    Browse the repository at this point in the history

  5. Respond to readability-related comments from the review

    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1ecb843 View commit details
    Browse the repository at this point in the history

  6. Don't pass NodeGroup as a parameter to functions running asynchronously

    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    257e66c View commit details
    Browse the repository at this point in the history

  7. Add unit test for group_deletion_scheduler

    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    5448bd2 View commit details
    Browse the repository at this point in the history

  8. Use single AtomicScaling option for scale up and scale down

    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    05e1fe1 View commit details
    Browse the repository at this point in the history

  9. Address next set of comments

    @kawych
    kawych committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    374cf61 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Bugfix for budget cropping 

    Previous "CropNodes" function of ScaleDownBudgetProcessor had an
assumption that atomically-scaled node groups should be classified as
"empty" or "drain" as a whole, however Cluster Autoscaler may classify
some of the nodes from a single group as "empty" and other as "drain".
    @kawych
    kawych committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    753b024 View commit details
    Browse the repository at this point in the history