fix: scale down broken for providers not implementing NodeGroup.GetOptions() #6038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Properly handle calls to
NodeGroup.GetOptions()that returncloudprovider.ErrNotImplementedin the scale down path.Previously scale down was broken for providers not implementing this method. I assume this was introduced in #5695 but did not do a bisect to figure out if this was actually the PR that broke it.
Which issue(s) this PR fixes:
Fixes #6037
Special notes for your reviewer:
There were a few more calls to
NodeGroup.GetOptions()that do not handlecloudprovider.ErrNotImplementedincluster-autoscaler/core/scaleup/orchestrator/orchestrator.go&cluster-autoscaler/core/static_autoscaler.go. I was not sure If these also need fixes, because the issue I was experiencing was related to scale down and went away with the changes in this PR.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: