Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused node-autoprovisioning-enabled and max-autoprovisioned-node-group-count flags #6246

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

prashantrewar
Copy link
Contributor

…d-node-group-count flags

What type of PR is this?

/kind bug
/kind deprecation

What this PR does / why we need it:

deprecating unused flags

Which issue(s) this PR fixes:

Fixes #
#6228

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @prashantrewar!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2023
@Shubham82
Copy link
Contributor

/retitle Deprecate unused node-autoprovisioning-enabled and max-autoprovisioned-node-group-count flags

@k8s-ci-robot k8s-ci-robot changed the title Deprecate unused node-autoprovisioning-enabled and max-autoprovisione… Deprecate unused node-autoprovisioning-enabled and max-autoprovisioned-node-group-count flags Nov 6, 2023
@towca
Copy link
Collaborator

towca commented Nov 10, 2023

/assign @towca

cluster-autoscaler/core/test/common.go Outdated Show resolved Hide resolved
…d-node-group-count flags

Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
@towca
Copy link
Collaborator

towca commented Dec 14, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prashantrewar, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit b95adf1 into kubernetes:master Dec 14, 2023
6 checks passed
@prashantrewar prashantrewar deleted the deprecate-unused-flag branch December 15, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants