Consider atomic nodes #6477
Merged
Consider atomic nodes #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
area/cluster-autoscaler
size/S
k8s-ci-robot
added
size/L
x13n
reviewed
Jan 31, 2024
| @@ -274,7 +276,7 @@ func (p *Planner) categorizeNodes(podDestinations map[string]bool, scaleDownCand | |||
| klog.Warningf("%d out of %d nodes skipped in scale down simulation due to timeout.", len(currentlyUnneededNodeNames)-i, len(currentlyUnneededNodeNames)) | |||
| break | |||
| } | |||
| if len(removableList) >= p.unneededNodesLimit() { | |||
| if len(removableList)-atomicScaleDownNodesCount >= p.unneededNodesLimit() { | |||
| klog.V(4).Infof("%d out of %d nodes skipped in scale down simulation: there are already %d unneeded nodes so no point in looking for more.", len(currentlyUnneededNodeNames)-i, len(currentlyUnneededNodeNames), len(removableList)) | |||
There was a problem hiding this comment.
Let's include atomicScaleDownNodesCount in the log.
There was a problem hiding this comment.
I meant in this line: just report atomicScaleDownNodesCount value. Doing it for every considered node is going to result in a lot of log spam.
There was a problem hiding this comment.
Makes sense. Done.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kushagra98, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
unneededNodesLimit()stops considering scale down nodes when this limit is reached. However, if a nodepool which has nodes > this limit and only allowed for atomic scaledown will always starve.Eg. Consider a nodepool with 1000 nodes in a cluster and
unneededNodesLimit()= 500. Let's consider that this nodepool is only allowed to scale down atomically. The nodepool will always starve for scale down as the limit is 500 but we cannot scaledown 500 nodes, we can only scale down 1000 nodes.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: