Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty ProviderID in ali NodeGroupForNode #6507

Conversation

daimaxiaxie
Copy link
Contributor

@daimaxiaxie daimaxiaxie commented Feb 6, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

When there is a node without an ProviderID in the ali cluster, then block main loop.

Which issue(s) this PR fixes:

Fixes #6546

Special notes for your reviewer:

The problem occurs in ali cloudprovider.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2024
@daimaxiaxie daimaxiaxie changed the title check empty ProviderID in ali NodeGroupForNode fix empty ProviderID in ali NodeGroupForNode Feb 20, 2024
@Shubham82
Copy link
Contributor

cc @ringtail

@ringtail
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@ringtail: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Shubham82
Copy link
Contributor

/lgtm
(as the above comment didn't apply the label)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@daimaxiaxie
Copy link
Contributor Author

rebase. Please @Shubham82 re-add LGTM label, thinks.

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2024
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daimaxiaxie, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 38124f2 into kubernetes:master Mar 15, 2024
6 checks passed
@daimaxiaxie daimaxiaxie deleted the check-empty-id-in-ali-NodeGroupForNode branch March 21, 2024 02:46
@gjtempleton
Copy link
Member

/area provider/alicloud

@k8s-ci-robot
Copy link
Contributor

@gjtempleton: The label(s) area/provider/alicloud cannot be applied, because the repository doesn't have them.

In response to this:

/area provider/alicloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gjtempleton gjtempleton added the area/provider/alicloud Issues or PRs related to the AliCloud cloud provider implementation label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/alicloud Issues or PRs related to the AliCloud cloud provider implementation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty ProviderID block RunOnce
6 participants