-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate GCE client to server-side wait #6547
Migrate GCE client to server-side wait #6547
Conversation
|
Welcome @mtrqq! |
80a2d00
to
5ddf45a
Compare
687f141
to
fa160c6
Compare
fa160c6
to
11076b6
Compare
cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client_test.go
Outdated
Show resolved
Hide resolved
11076b6
to
1928fe5
Compare
1928fe5
to
27b4c19
Compare
cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client_test.go
Outdated
Show resolved
Hide resolved
27b4c19
to
8a3b6cc
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrqq, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
GCE CloudProvider is currently using polling as a primary method for awaiting async operations. GCE now provides method for server side wait, which will decrease RPS compared to polling approach.
Special notes for your reviewer:
Does this PR introduce a user-facing change?