Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GCE client to server-side wait #6547

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

mtrqq
Copy link
Contributor

@mtrqq mtrqq commented Feb 20, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

GCE CloudProvider is currently using polling as a primary method for awaiting async operations. GCE now provides method for server side wait, which will decrease RPS compared to polling approach.

Special notes for your reviewer:

  1. WaitForOperation method becomes part of public interface to allow further extension of interface without reimplementing await logic once again;
  2. In case we are sure that timeouts more than 2 minutes are required we may combine wait method with polling as the last resort.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 20, 2024
Copy link

linux-foundation-easycla bot commented Feb 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mtrqq / name: Maksym Fuhol (8a3b6cc)

@k8s-ci-robot k8s-ci-robot added area/provider/gce cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 20, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @mtrqq!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 20, 2024
@mtrqq mtrqq marked this pull request as ready for review February 20, 2024 08:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2024
@mtrqq mtrqq force-pushed the feat/gce-server-side-wait branch 2 times, most recently from 687f141 to fa160c6 Compare February 20, 2024 09:56
@mtrqq mtrqq force-pushed the feat/gce-server-side-wait branch from fa160c6 to 11076b6 Compare March 7, 2024 08:23
@mtrqq mtrqq requested a review from towca March 7, 2024 08:27
@mtrqq mtrqq force-pushed the feat/gce-server-side-wait branch from 11076b6 to 1928fe5 Compare March 13, 2024 13:25
@mtrqq mtrqq requested a review from towca March 13, 2024 13:25
@mtrqq mtrqq force-pushed the feat/gce-server-side-wait branch from 1928fe5 to 27b4c19 Compare March 13, 2024 13:54
@mtrqq mtrqq force-pushed the feat/gce-server-side-wait branch from 27b4c19 to 8a3b6cc Compare March 13, 2024 22:44
@mtrqq mtrqq requested a review from towca March 13, 2024 22:50
@towca
Copy link
Collaborator

towca commented Mar 14, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrqq, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 586137e into kubernetes:master Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants