Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Linode Cluster Autoscaler provider #6613

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

kokes
Copy link
Contributor

@kokes kokes commented Mar 11, 2024

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

The Linode provider for CA has been redundant for years now and should be deprecated (and eventually removed).

Which issue(s) this PR fixes:

Fixes #6495

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The Linode Cluster Autoscaler provider is removed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

Signed-off-by: Ondrej Kokes <ondrej.kokes@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @kokes!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/linode Issues or PRs related to linode provider labels Mar 11, 2024
@elmiko
Copy link
Contributor

elmiko commented Mar 11, 2024

been talking about this with @kokes on slack, i think this is a solid first step towards removing this provider.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@gjtempleton
Copy link
Member

gjtempleton commented Mar 11, 2024

I think on past deprecations (though I now can't find which ones... @MaciekPytel can you remember which deprecation(s) we followed this for?) we chose to match the CLI deprecation policy of marking as deprecated for 2 releases, so we could choose to be more specific and say that it'll only continue to function as far as the CA v1.32.x release?

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kokes, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit eae11e7 into kubernetes:master Mar 20, 2024
6 checks passed
@kokes kokes deleted the deprecate_linode branch March 20, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/linode Issues or PRs related to linode provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Deprecate Linode autoscaler implementation
5 participants