-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CA golang to 1.22.1 #6635
Bump CA golang to 1.22.1 #6635
Conversation
@azylinski: GitHub didn't allow me to assign the following users: olagacek. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@azylinski: GitHub didn't allow me to request PR reviews from the following users: pmendelski, damikag. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: azylinski, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -21,6 +21,6 @@ ENV GO111MODULE auto | |||
|
|||
RUN apt-get update && apt-get --yes install libseccomp-dev | |||
RUN go version | |||
RUN go get github.com/tools/godep | |||
RUN go install github.com/tools/godep@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need godep
for anything? CA is using go modules for a while now.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump
cluster-autoscaer
golang version to match k/k:kubernetes/kubernetes@70221e8
Does this PR introduce a user-facing change?
/assign @olagacek
/cc @damikag
/cc @pmendelski