Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CA golang to 1.22.1 #6635

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

azylinski
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump cluster-autoscaer golang version to match k/k:
kubernetes/kubernetes@70221e8

Does this PR introduce a user-facing change?

NONE

/assign @olagacek
/cc @damikag
/cc @pmendelski

@k8s-ci-robot
Copy link
Contributor

@azylinski: GitHub didn't allow me to assign the following users: olagacek.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump cluster-autoscaer golang version to match k/k:
kubernetes/kubernetes@70221e8

Does this PR introduce a user-facing change?

NONE

/assign @olagacek
/cc @damikag
/cc @pmendelski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 18, 2024
@k8s-ci-robot
Copy link
Contributor

@azylinski: GitHub didn't allow me to request PR reviews from the following users: pmendelski, damikag.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump cluster-autoscaer golang version to match k/k:
kubernetes/kubernetes@70221e8

Does this PR introduce a user-facing change?

NONE

/assign @olagacek
/cc @damikag
/cc @pmendelski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/cluster-autoscaler labels Mar 18, 2024
@azylinski azylinski changed the title Bump CA golang to 1.22 Bump CA golang to 1.22.1 Mar 18, 2024
@towca
Copy link
Collaborator

towca commented Mar 18, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2024
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: azylinski, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
@@ -21,6 +21,6 @@ ENV GO111MODULE auto

RUN apt-get update && apt-get --yes install libseccomp-dev
RUN go version
RUN go get github.com/tools/godep
RUN go install github.com/tools/godep@latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need godep for anything? CA is using go modules for a while now.

@k8s-ci-robot k8s-ci-robot merged commit eb5d875 into kubernetes:master Mar 18, 2024
6 checks passed
@azylinski azylinski deleted the bump-ca-go-1-22 branch March 18, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants