[v1.28] fix(hetzner): hostname label is not considered #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The Node Group info we currently return does not include the `kubernetes.io/hostname` label, which is usually set on every node. This causes issues when the user has an unscheduled pod with a `topologySpreadConstraint` on `topologyKey: kubernetes.io/hostname`. cluster-autoscaler is unable to fulfill this constraint and does not scale up any of the node groups. Related to kubernetes#6715
apricote
force-pushed
the
hetzner-missing-hostname-labels-1.28
branch
from
e06f2af
to
126765f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
merged commit 03f37df
into
kubernetes:cluster-autoscaler-release-1.28
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area provider/hetzner
What this PR does / why we need it:
The Node Group info we currently return does not include the
kubernetes.io/hostnamelabel, which is usually set on every node.This causes issues when the user has an unscheduled pod with a
topologySpreadConstraintontopologyKey: kubernetes.io/hostname. cluster-autoscaler is unable to fulfill this constraint and does not scale up any of the node groups.Backport of #6740 to v1.28 branch.
Which issue(s) this PR fixes:
Related to #6715
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: