Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DecreaseTargetSize to Exclude Placeholders #6866

Closed
wants to merge 1 commit into from
Closed

Update DecreaseTargetSize to Exclude Placeholders #6866

wants to merge 1 commit into from

Commits on May 26, 2024

  1. Update DecreaseTargetSize to Exclude Placeholders 

    This commit updates the DecreaseTargetSize function in the AWS cloud provider module of the cluster-autoscaler to address a potential deadlock scenario. The function was modified to filter out placeholder nodes marked as 'placeholderUnfulfillableStatus' before determining if a decrease in target size is allowable. This change ensures that the scaling process considers only operational nodes, which enhances the stability and manageability of AWS Auto Scaling Groups.

- Added checks to specifically exclude placeholders in the DecreaseTargetSize calculations.
- Enhanced the logging to provide better clarity when instance statuses are fetched, continuing the process despite potential errors.

Refer to discussion in issue 6128 for more details on the scenarios and reproduction steps that guided these enhancements.
    @ruiscosta
    ruiscosta committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b0fea21 View commit details
    Browse the repository at this point in the history