Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #6528 [CA] Fix expectedToRegister to respect instances with nil status into CA1.29 #6893

Conversation

Shubham82
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is cherry-picked, which backports #6528 into CA 1.28

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2024
@Shubham82
Copy link
Contributor Author

Hi @feiskyer, @x13n
PTAL!

@x13n
Copy link
Member

x13n commented Jun 7, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shubham82, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 90591b5 into kubernetes:cluster-autoscaler-release-1.29 Jun 7, 2024
6 checks passed
@agamez-harmonicinc
Copy link

Is this fix available for all 1.29 versions? I've faced this problem is CA 1.29.3 a couple of days ago.

@Shubham82
Copy link
Contributor Author

Hi @agamez-harmonicinc No, this fix is available in the CA v1.29.4 version for v1.29
Please take a look at this:
https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.29.4

@agamez-harmonicinc
Copy link

Thanks a lot @Shubham82 , appreciate the quick response

@Shubham82
Copy link
Contributor Author

Thanks a lot @Shubham82 , appreciate the quick response

You're Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants