-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPA: Fix regression where the case of Kind is inconsistant #6929
Conversation
Relates to kubernetes#6924 Previously the case of the `Kind` in the `targetRef` didn't matter. Not it seems to matter for the admission-controller. This change attempts to copy what the HPA does. https://github.com/kubernetes/kubernetes/blob/v1.30.0/pkg/controller/podautoscaler/horizontal.go#L1321-L1325
Hi @adrianmoisey. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/area vertical-pod-autoscaler |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adrianmoisey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I don't think this is the right approach. Going to close this and see if I can get conversation going on the issue. |
Relates to #6924
Previously the case of the
Kind
in thetargetRef
didn't matter. Not it seems to matter for the admission-controller.This change attempts to copy what the HPA does. https://github.com/kubernetes/kubernetes/blob/v1.30.0/pkg/controller/podautoscaler/horizontal.go#L1321-L1325
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
This PR allows users to specify a kind in the targetRef and all 3 VPA components will still continue to work.
Prior to this change the admission-controller would ignore the new Pods if the case of the
Kind
was incorrect.Which issue(s) this PR fixes:
Fixes # #6924
Special notes for your reviewer:
I'm not sure if this solution is the right way to go, but I copied the HPA as best I could, in order to maintain consistent behaviour between the VPA and HPA.
Another solution could be to change this line:
autoscaler/vertical-pod-autoscaler/pkg/utils/vpa/api.go
Line 167 in 131d12b
It could do a strings.ToLower() before comparison.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: