-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VMs pool] Add implementation for VMs pool #6951
Open
wenxuan0923
wants to merge
16
commits into
kubernetes:master
Choose a base branch
from
wenxuan0923:wenx/vms-impl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,255
−189
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0b2c0f4
[VMs pool] Add implementation for VMs pool
wenxuan0923 71a2e6b
Fx golint
wenxuan0923 26d5fe1
Address comments
wenxuan0923 85a9d68
Remove some logs
wenxuan0923 4407a79
Use utility method to parse machine name
wenxuan0923 ab9d486
Bump armcontainerservice to v5
wenxuan0923 cdeae25
Return error for DecreaseTargetSize
wenxuan0923 a0143a4
Fx gomock
wenxuan0923 8723021
Fx Boilerplate header
wenxuan0923 0d941a1
Resolve conflicts
wenxuan0923 e964b77
Deal with 0 node vms pool for register
wenxuan0923 45d1dad
Introduce Node Template
wenxuan0923 33c6330
Change vmsPoolSet to vmsPoolMap
wenxuan0923 eefca96
Support TemplateNodeInfo
wenxuan0923 bef048c
Fx golint
wenxuan0923 5422bd8
Add many UTs
wenxuan0923 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this support
UseWorkloadIdentityExtension
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure...but it should be fairly easy to add it if needed later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't be used for managed, but it is the preferred method of authentication for self-hosted at the moment. I would recommend you add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding to what robin said, the workload identity extension gets addressed in this function below: https://github.com/kubernetes/autoscaler/pull/6951/files#diff-e18278caa19fbc44db54dcd3c6d8e77d045fff33e3a7cd0b6a65f5a111543b83R288-R354
so I'd look into reusing this function. we use workload identity for local testing + dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the code to support UseWorkloadIdentityExtension