Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Azure Provider HasInstance implementation #6956

Merged
merged 27 commits into from
Jul 31, 2024
Merged

feat: Azure Provider HasInstance implementation #6956

merged 27 commits into from
Jul 31, 2024

Commits on Jul 31, 2024

  1. feat: HasInstance implementation

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c90a262 View commit details
    Browse the repository at this point in the history

  2. fix: ci lint

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    17cee14 View commit details
    Browse the repository at this point in the history

  3. refactor: cloudprovider HasInstance should use case sensitive instanc… 

    …e group lookup
    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3ee8d1c View commit details
    Browse the repository at this point in the history

  4. feat: using NodeGroupForNode for the azure provider has instance impl… 

    …ementation
    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9be9604 View commit details
    Browse the repository at this point in the history

  5. fix: ci lint 

    fix: ci
    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    27e3e97 View commit details
    Browse the repository at this point in the history

  6. wip: HasInstance impl based on a fork of NodeGroupForNode

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    39d0882 View commit details
    Browse the repository at this point in the history

  7. refactor: refactoring tests and sharing validation between ngfornode … 

    …+ hasinstance
    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e48a743 View commit details
    Browse the repository at this point in the history

  8. test: removing commented out test

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    24fbfff View commit details
    Browse the repository at this point in the history

  9. ci: fix formatting

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a48dd71 View commit details
    Browse the repository at this point in the history

  10. fix: properly handling unmanaged nodes

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    20129ed View commit details
    Browse the repository at this point in the history

  11. fix: removing unused helper

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    15a0e40 View commit details
    Browse the repository at this point in the history

  12. fix: using provider id to get scaleset name

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    79ac01e View commit details
    Browse the repository at this point in the history

  13. fix: putting items into the set as lowercase to avoid mismatch in lookup

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9b8691d View commit details
    Browse the repository at this point in the history

  14. Update cluster-autoscaler/cloudprovider/azure/azure_cloud_provider.go 

    Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
    @Bryce-Soghigian @tallaxes
    Bryce-Soghigian and tallaxes committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    5b4255f View commit details
    Browse the repository at this point in the history

  15. fix: always fallback if we are unsure an instance is in the cache

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e7a2881 View commit details
    Browse the repository at this point in the history

  16. test: adding back in TestNodeGroupForNodeWithNoProviderID

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    349c80b View commit details
    Browse the repository at this point in the history

  17. refactor: removing log lines since this will spam for non-autoscaled … 

    …nodes
    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1a8bfb6 View commit details
    Browse the repository at this point in the history

  18. refactor: removing dead code

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    2c065f6 View commit details
    Browse the repository at this point in the history

  19. fix: simplifying logic since we no longer distinguish on delete

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    476e275 View commit details
    Browse the repository at this point in the history

  20. Update cluster-autoscaler/cloudprovider/azure/azure_cache.go

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    0793422 View commit details
    Browse the repository at this point in the history

  21. test: renaming test to better reflect the scenario

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    eba8653 View commit details
    Browse the repository at this point in the history

  22. Update cluster-autoscaler/cloudprovider/azure/azure_cache.go 

    Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
    @Bryce-Soghigian @tallaxes
    Bryce-Soghigian and tallaxes committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3cc1dcf View commit details
    Browse the repository at this point in the history

  23. refactor: removing shared helpers since they are no longer shared and… 

    … didnt make any sense in the first place
    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    59356d5 View commit details
    Browse the repository at this point in the history

  24. refactor: removing unused code and adding a test for has instance hap… 

    …py path
    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    008161e View commit details
    Browse the repository at this point in the history

  25. Update cluster-autoscaler/cloudprovider/azure/azure_cache.go

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    25a4f9a View commit details
    Browse the repository at this point in the history

  26. ci: lint

    @Bryce-Soghigian
    Bryce-Soghigian committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4a4ea9e View commit details
    Browse the repository at this point in the history

  27. Update cluster-autoscaler/cloudprovider/azure/azure_cache.go 

    Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
    @Bryce-Soghigian @tallaxes
    Bryce-Soghigian and tallaxes committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    34a26ee View commit details
    Browse the repository at this point in the history