-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow removing some volumes so that bounded PV check can pass when scaling down #6976
Conversation
Hi @jewelzqiu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jewelzqiu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@x13n Hi, I have resubmitted the PR, because specifying |
@wackxu check this PR |
Can you clarify which check is failing on scale down for bounded PV? |
Ok, I went through the linked issue, looks like the problem is with logic checking whether other nodes in the cluster would be able to run the pod. They can't because local volume has affinity to a specific node. The change currently proposed in this PR might work, though I think modifying pod object in place like this is error prone: this is supposed to be a check, not a mutable operation on pod objects. A better place to remove these volumes would be during simulation of node removal. We're already making a copy of the object there: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/simulator/cluster.go#L229 |
I'm closing this due to lack of activity. If anyone wants to pick up this work, I'd actually suggest making it work for both scale up and scale down paths - to both unblock scale down of pods with local PV and prevent such pods from getting stuck pending. /close |
@x13n: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #6417
Special notes for your reviewer:
Previous PR: #6418
Specifying
--skip-nodes-with-local-storage=false
won't help, because this flag only affects drainable checkAfter drainable check, the pod will enter bounded PV check where it will fail
(because local pv is bounded to the specified node)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: