-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set State to InstanceCreating for nodes that failed to join cluster #6978
base: master
Are you sure you want to change the base?
Set State to InstanceCreating for nodes that failed to join cluster #6978
Conversation
Hi @vbhargav875. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a86c846
to
4ab159b
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlamillan, vbhargav875 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vbhargav875 might want to rebase your commit against the latest to re-run failed test |
What type of PR is this?
/kind bug
What this PR does :
Cluster Autoscaler only handles deleting of cloud-provider instances that do not join the cluster within the max-node-provision-time only if the state of the cloud-provider instance is set to InstanceCreating. [Code Link]
This PR is set to the state of cloud-provider instance which have failed to InstanceCreating.