-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI: Fixing scale from zero if the nodeSelector of workload contains 'node.kubernetes.io/instance-type' #6993
OCI: Fixing scale from zero if the nodeSelector of workload contains 'node.kubernetes.io/instance-type' #6993
Conversation
….kubernetes.io/instance-type'
Welcome @robert-heinzmann-logmein! |
Hi @robert-heinzmann-logmein. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @robert-heinzmann-logmein, you have to sign the CLA before the PR can be reviewed. |
To check EasyCLA /easycla |
Done |
/ok-to-test |
It looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlamillan, robert-heinzmann-logmein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently if workload contains a
nodeSelector
such asthen scale from zero does not work as
shape.Name
is not initialized during the templateNode creation.Which issue(s) this PR fixes:
Special notes for your reviewer:
This should be backported / cherry picked for all supported OKE versions such as 1.30 (upcoming), 1.29, 1.28
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: