Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use project name instead of project number in createIgmRef() #7004

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Use project name instead of project number in createIgmRef() #7004

merged 1 commit into from
Jul 9, 2024

Conversation

damikag
Copy link
Contributor

@damikag damikag commented Jul 4, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR updates project field of GceRef returned by createIgmRef() in autoscaling_gce_client.go to use project name instead of project number. created-by field in instances returned by Instances.List() have project id but CA use project names in MIG refs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 4, 2024
@k8s-ci-robot k8s-ci-robot requested a review from x13n July 4, 2024 15:03
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/gce needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @damikag. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 4, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 4, 2024
@damikag damikag changed the title Refactor mig fetch 2 Use project name instead of project number in createIgmRef() Jul 4, 2024
bskiba
bskiba reviewed Jul 8, 2024
View reviewed changes
cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go
@@ -425,6 +425,7 @@ func createIgmRef(gceInstance *gce.Instance, loggingQuota *klogx.Quota) GceRef {
klogx.V(5).UpTo(loggingQuota).Infof("Unable to parse IGM for %v because of %v", gceInstance.SelfLink, err)
return GceRef{}
}
igmRef.Project = project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a comment on why we need to overwrite the project. I'm wondering also if it would be better for ParseIgmUrl to only fill in zone and igm name and not the project. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to describe why we overwrite the project.

What do you think of keeping the PraseIgmUrl as it is since it is a generic function that somebody can use elsewhere?

bskiba
bskiba reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@bskiba bskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@x13n
Copy link
Member

x13n commented Jul 9, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba, damikag, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@x13n
Copy link
Member

x13n commented Jul 9, 2024

/lgtm

Looks like a rebase, reapplying lgtm.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 9, 2024
@x13n
Copy link
Member

x13n commented Jul 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 286e61d into kubernetes:master Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bskiba bskiba bskiba left review comments

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@x13n x13n Awaiting requested review from x13n

Assignees

@x13n x13n

@bskiba bskiba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damikag @k8s-ci-robot @x13n @bskiba