-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: failed get correct asgs when use multiple --node-group-auto-disco… #7009
base: master
Are you sure you want to change the base?
Conversation
Welcome @maoqide! |
Hi @maoqide. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maoqide The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
677d897
to
529277c
Compare
…very
What type of PR is this?
/kind bug
What this PR does / why we need it:
when use multiple --node-group-auto-discovery and --cloud-provider=aws in args, cluster-autoscaler can‘t get correct ags from aws as we expected. for example:
I started cluster-autoscaler with:
I wanted cluster-autoscaler to fetch all asgs satisfied with
taga=a
ortagb=b
.however, I found it fetched asgs satisfied both with
taga=a
andtagb=b
. In fact, it just merged two--node-group-auto-discovery
args into one.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: