Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster-autoscaler-release-1.30] Add support for all-or-nothing scale-up strategy #7015

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #6821

/assign yaroslava-serdiuk

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2024
@k8s-ci-robot k8s-ci-robot requested a review from x13n July 9, 2024 08:47
@yaroslava-serdiuk
Copy link
Contributor

/assign @towca

@yaroslava-serdiuk
Copy link
Contributor

/assign @x13n

@yaroslava-serdiuk
Copy link
Contributor

#6815

@x13n
Copy link
Member

x13n commented Jul 11, 2024

If this needs to go to 1.30, please update the release note so that there's a menaingful update I can put in the changelog.

@yaroslava-serdiuk
Copy link
Contributor

@x13n this is part of implementation of best-effort-atomic provisioning class. When this is cherry-picked, I would cherry-pick #6824 and copy release notes from it.

@x13n
Copy link
Member

x13n commented Jul 11, 2024

Makes sense, thanks.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit bf7bbda into kubernetes:cluster-autoscaler-release-1.30 Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants