-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metrics for function duration for listing gce instances and metrics for inconsistent mig count when gce bulk instance listing is enabled #7027
Conversation
Hi @damikag. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1cc86e5
to
7d12d92
Compare
3cea35d
to
f8719af
Compare
/lgtm |
f8719af
to
070f95e
Compare
070f95e
to
3db9bf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just minor comments.
8b8a9fe
to
6c4d7d2
Compare
…and for listing migInstances add metrics for inconsistent mig count
6c4d7d2
to
9eb7d2f
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba, damikag, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR emits function duration metrics for listing all mig instances and listing instances using
igm.ListManagedInstances()
, when bulk listing gce instances is enabled.And also emits inconsistent mig count for the number of migs which have a difference in instance count based on actionsSummary and result from bulk listing instances.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: