Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics for function duration for listing gce instances and metrics for inconsistent mig count when gce bulk instance listing is enabled #7027

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

damikag
Copy link
Contributor

@damikag damikag commented Jul 10, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR emits function duration metrics for listing all mig instances and listing instances using igm.ListManagedInstances(), when bulk listing gce instances is enabled.

And also emits inconsistent mig count for the number of migs which have a difference in instance count based on actionsSummary and result from bulk listing instances.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 10, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 10, 2024
@k8s-ci-robot k8s-ci-robot requested a review from x13n July 10, 2024 09:49
@k8s-ci-robot k8s-ci-robot added area/provider/gce needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @damikag. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2024
@damikag damikag force-pushed the refactor-mig-fetch branch 2 times, most recently from 1cc86e5 to 7d12d92 Compare July 10, 2024 11:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2024
@damikag damikag force-pushed the refactor-mig-fetch branch 2 times, most recently from 3cea35d to f8719af Compare July 10, 2024 11:51
@bskiba
Copy link
Member

bskiba commented Jul 11, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
Copy link
Member

@x13n x13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments.

cluster-autoscaler/cloudprovider/gce/mig_info_provider.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/gce/mig_info_provider.go Outdated Show resolved Hide resolved
@damikag damikag force-pushed the refactor-mig-fetch branch 2 times, most recently from 8b8a9fe to 6c4d7d2 Compare July 12, 2024 09:24
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2024
…and for listing migInstances

add metrics for inconsistent mig count
@x13n
Copy link
Member

x13n commented Jul 12, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba, damikag, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5dc4ec4 into kubernetes:master Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants