-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAS azure e2e: add namespace to all resources in CAPZ template #7052
CAS azure e2e: add namespace to all resources in CAPZ template #7052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold to make sure this actually fixes the test |
/lgtm (regardless of whether or not this fixes tests I'm always +1 on explicit namespace declarations) |
e812f41
to
4104ea7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, nojnhuh, willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
All green! /hold cancel |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
Adds
metadata.namespace
to a couple of lingering resources in the CAPZ template used for cluster-autoscaler e2e tests where it wasn't already defined.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: