-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster-autoscaler-release-1.30] allow customizing user agent for Azure cluster-autoscaler provider #7053
Conversation
/retest |
@jackfrancis The release branches don't have the tests defined that the test-infra config assumes, so e2e tests here will fail until we backport them. We'll also need changes in test-infra to make sure the test cluster is using the right version of k8s. Are those changes worth making soon? |
@nojnhuh let's do that after the 1.31 release (which will include the necessary test files from main that landed in advance of the 1.31 release) |
@k8s-infra-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
hold till CA 1.31 release /hold |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
112e7f0
into
kubernetes:cluster-autoscaler-release-1.30
This is an automated cherry-pick of #7033
/assign nojnhuh