Extract getting nodes to delete for atomic node groups #7068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
area/cluster-autoscaler
size/L
|
/assign @kawych |
kawych
reviewed
Jul 26, 2024
bskiba
force-pushed
the
cleanup-for-stockout-2
branch
from
fe4afe4 to
b9b7b34
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
kawych
approved these changes
Jul 30, 2024
Extract logic for overriding nodes to delete when deleting nodes from a ZeroOrMaxNodeScaling node group. Simplifies the code and removes code duplication.
bskiba
force-pushed
the
cleanup-for-stockout-2
branch
from
b9b7b34 to
14b3357
Compare
k8s-ci-robot
removed
the
lgtm
|
Thanks! Squashed the commits. @aleksandra-malinowska would you be able to take a look and approve if it looks ok? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksandra-malinowska, bskiba, kawych The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract logic for overriding nodes to delete when deleting nodes from a ZeroOrMaxNodeScaling node group.
Simplifies the code and removes code duplication.
What type of PR is this?
/kind cleanup
-->
What this PR does / why we need it:
Extract logic for overriding nodes to delete when deleting nodes from a ZeroOrMaxNodeScaling node group.
Simplifies the code and removes code duplication.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: