Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA: AWS add support for Nvidia L40s GPU instances #7181

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

kamalkraj
Copy link
Contributor

@kamalkraj kamalkraj commented Aug 19, 2024

What type of PR is this?

/kind feature
Add new gpu type for auto scaling.

What this PR does / why we need it:

For GPU auto-scaling - https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#special-note-on-gpu-instances

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2024
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kamalkraj. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2024
@kamalkraj
Copy link
Contributor Author

@gjtempleton Please review.

Also need to merge this PR to make the g6e instance properly work with autoscaler
#7177

@gjtempleton
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, kamalkraj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit a403250 into kubernetes:master Sep 23, 2024
6 checks passed
@gjtempleton
Copy link
Member

/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31

@k8s-infra-cherrypick-robot

@gjtempleton: #7181 failed to apply on top of branch "cluster-autoscaler-release-1.28":

Applying: Update aws_cloud_provider.go
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/aws/aws_cloud_provider.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/cloudprovider/aws/aws_cloud_provider.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/aws/aws_cloud_provider.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update aws_cloud_provider.go
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gjtempleton
Copy link
Member

/cherry-pick cluster-autoscaler-release-1.28

@k8s-infra-cherrypick-robot

@gjtempleton: new pull request created: #7354

In response to this:

/cherry-pick cluster-autoscaler-release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gjtempleton
Copy link
Member

/cherry-pick cluster-autoscaler-release-1.29

@gjtempleton
Copy link
Member

/cherry-pick cluster-autoscaler-release-1.30

@gjtempleton
Copy link
Member

/cherry-pick cluster-autoscaler-release-1.31

@k8s-infra-cherrypick-robot

@gjtempleton: new pull request created: #7355

In response to this:

/cherry-pick cluster-autoscaler-release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@gjtempleton: new pull request created: #7356

In response to this:

/cherry-pick cluster-autoscaler-release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@gjtempleton: new pull request created: #7357

In response to this:

/cherry-pick cluster-autoscaler-release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants