-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA: add artifacts for dev testing of cluster-autoscaler on AKS #7187
CA: add artifacts for dev testing of cluster-autoscaler on AKS #7187
Conversation
Welcome @charliedmcb! |
Hi @charliedmcb. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @charliedmcb |
To check EasyCLA /easycla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks! I have completed the CLA. |
/easycla |
/ok-to-test |
/easycla |
337a0e6
to
2d79167
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charliedmcb, comtalyst, rakechill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds the required artifacts, and documentation for testing of cluster-autoscaler changes within a dev environment on an AKS cluster.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
While this is mostly meant to support the https://github.com/Azure/autoscaler repo dev environment, I think this is valuable to have upstream in the https://github.com/kubernetes/autoscaler repo for others to see the process for testing in a dev environment, and can be leveraged as a base for setting up ones own tests.
Testing:
azure/autoscaler
, transferred to themain
branch of this repo, and then used the artifacts to setup a running instance of autoscaler on the aks cluster in my codespace.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: