chore: backport latest VMs pool and HasInstance() implementations and resolve inconsistencies in config and unit tests, for 1.29 #7202
Conversation
… resolve inconsistencies in config and unit tests
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
area/provider/azure
k8s-ci-robot
added
approved
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
@comtalyst: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
comtalyst
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, tallaxes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/retest |
|
/retest pull-cluster-autoscaler-e2e-azure |
|
@comtalyst: The
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-autoscaler-e2e-azure |
|
@comtalyst: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
This job no longer exists for this branch as of kubernetes/test-infra#33361 /override pull-cluster-autoscaler-e2e-azure |
I suppose this command isn't registered for the repo? https://prow.k8s.io/command-help?repo=kubernetes%2Fautoscaler I'll try making a fix in test-infra to add this back just as a stub so as not to block any PRs for the time being. |
|
/test pull-cluster-autoscaler-e2e-azure |
k8s-ci-robot
merged commit aa12b49
into
kubernetes:cluster-autoscaler-release-1.29
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
These differences have effectively disabled cherry-pick automation in these areas. Upcoming changes (e.g., more VMs pool implementation, cloud-provider-azure integration rework, more fixes that need to be done in all versions) will be agonizing experiences, not to mention the past ones.
This PR will amend some of those differences, which is mostly VMs pool and HasInstance() implementations, as well as known inconsistencies in config and unit tests. The latter has known to bother us in various circumstances.
They cannot be cherry-picked in normal means easily due to conflict with Azure defork operations, which have to resolve these conflicts at some point anyway.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Original
HasInstance()implementation PR: #6956Differences visualization I used as a reference, with some labels: https://github.com/comtalyst/autoscaler/pull/5/files
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: