Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: document migration to new GPU Node label #7203

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 23, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR documents the Azure provider's plan to migrate to a new label used to identify GPU Nodes in order to align with the labels used by AKS: https://learn.microsoft.com/en-us/azure/aks/use-labels#deprecated-labels

The rough plan is to:

  • document that users need to set BOTH the current and new labels on GPU Nodes (this PR)
  • wait for at least one minor version release cycle to allow users time to add the new label (until at least cluster-autoscaler 1.32)
  • change the Azure provider from identifying GPU Nodes based on the old label to the new one

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ACTION REQUIRED: VMSS GPU Nodes must now also include the `kubernetes.azure.com/accelerator` label in addition to `accelerator`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2024
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 23, 2024

/assign @comtalyst

@comtalyst
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: comtalyst, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2caebb9 into kubernetes:master Aug 23, 2024
6 of 7 checks passed
@nojnhuh nojnhuh deleted the readme-gpu-label branch August 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants