Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy scale down code #7219

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

x13n
Copy link
Member

@x13n x13n commented Aug 28, 2024

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Legacy scale down logic didn't support draining multiple nodes simultaneously. Now that the new implementation has been stable for more than a year, it is time to drop the legacy logic.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I had to change unit tests a bit - the legacy logic used PDBs a bit differently, so number of List calls changed. I also made a few minor improvements to improve stability of static_autoscaler_test.go.
Another notable is ScaleDownNoUnneeded scale down status removal - it was only used in the legacy implementation.

Does this PR introduce a user-facing change?

`--parallel-drain` flag was removed. To ensure only one node is drained at the same time, use `--max-drain-parallelism=1`.
`--max-empty-bulk-delete` flag was deprecated. It still works, but is equivalent to and will be replaced by `--max-scale-down-parallelism` in a future release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 28, 2024
This was only used by legacy scale down implementation.
@towca
Copy link
Collaborator

towca commented Aug 28, 2024

👷
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: towca, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c27e40d into kubernetes:master Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants