Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
Legacy scale down logic didn't support draining multiple nodes simultaneously. Now that the new implementation has been stable for more than a year, it is time to drop the legacy logic.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I had to change unit tests a bit - the legacy logic used PDBs a bit differently, so number of List calls changed. I also made a few minor improvements to improve stability of
static_autoscaler_test.go
.Another notable is
ScaleDownNoUnneeded
scale down status removal - it was only used in the legacy implementation.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: