-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glog terminates program when it can't create a logfile #358
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/reopen |
@hjacobs: you can't re-open an issue/PR unless you authored it or you are assigned to it. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@destructive-dragon do you have any pointers for me where you (or someone else) applied a workaround to disable |
You could either just try to fork the original glog and change the lines of code that do the Exit / require the files. This is a good starting point: https://github.com/golang/glog/blob/master/glog.go#L679 Or the way I solved it was to just reimplement all the glog functions and wrapped them straight onto a go-kit logger without all the complex Verbosity logic (see https://github.com/kubermatic/glog-gokit as an example) See also: #18 (comment) |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/reopen |
@hjacobs: you can't re-open an issue/PR unless you authored it or you are assigned to it. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Fix for External DNS to replace glog with a sane version (for anybody interested): kubernetes-sigs/external-dns#714 |
There's a core Kubernetes issue open for this: kubernetes/kubernetes#61006 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale Kubernetes core switched to |
Looks like 74cd8bb has addressed this by switching to klog as of v10.0.0, though it's not called out in the Changelog. |
@gjtempleton that would be awesome! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten Switching to klog doesn't fully resolve this, at least by default. (See: projectcalico/typha#258 and coredns/coredns#2529 ) |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is quite a big deal when using with containerized read-only environments. We should absolutely get rid of glog as it just calls
os.Exit(2)
if it can't create a file, killing our entire process.A workaround would be to do all calls to glog inside a seperate process, which shouldn't be worth the hassle.
The text was updated successfully, but these errors were encountered: