-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update pause-win image to the new one k8s.gcr.io/pause:3.4.1 #186
Conversation
can I get a review 😄 |
@@ -51,7 +51,7 @@ | |||
# - Document functions using proper syntax: | |||
# https://technet.microsoft.com/en-us/library/hh847834(v=wps.620).aspx | |||
|
|||
$INFRA_CONTAINER = 'gcr.io/gke-release/pause-win:1.1.0' | |||
$INFRA_CONTAINER = 'k8s.gcr.io/pause:3.4.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please let's add this to build/dependencies.yaml in the "dependents" entry so we don't de-sync it again 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, did not follow you, add where? should we remove it from this file? I'm sorry for the dumb question, not clear to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not at all, sorry somehow I thought I'd already seen you interact with this:
https://github.com/kubernetes/kubernetes/blob/473af0b8d1951b5c362df60925bb8d9fb007fab9/build/dependencies.yaml#L162
we have a presubmit that ensures that the versions are in sync based on the (filepath, regex) specs in that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add these references to the pause image to that list so when pause is updated again someday the presubmit will catch if these new references added in this PR aren't updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL wrong repo. bentheelder is taking a long nap soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wishful thinking. sorry about that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As part of the efforts described in this Issue: kubernetes/k8s.io#1525 we are trying to move away from
gcp project gke-release
Also the pause image was release with windows support as we can see in the merged or in k/k kubernetes/kubernetes#98205
/assign @spiffxp @saad-ali