Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update pause-win image to the new one k8s.gcr.io/pause:3.4.1 #186

Merged
merged 1 commit into from
Feb 19, 2021
Merged

test: update pause-win image to the new one k8s.gcr.io/pause:3.4.1 #186

merged 1 commit into from
Feb 19, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 11, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As part of the efforts described in this Issue: kubernetes/k8s.io#1525 we are trying to move away from gcp project gke-release

Also the pause image was release with windows support as we can see in the merged or in k/k kubernetes/kubernetes#98205

/assign @spiffxp @saad-ali

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2021
@cpanato
Copy link
Member Author

cpanato commented Feb 18, 2021

can I get a review 😄
/assign @BenTheElder @amwat
/unassign @saad-ali

@k8s-ci-robot k8s-ci-robot assigned amwat and BenTheElder and unassigned saad-ali Feb 18, 2021
BenTheElder
BenTheElder reviewed Feb 18, 2021
View reviewed changes
cluster/gce/windows/k8s-node-setup.psm1
@@ -51,7 +51,7 @@
# - Document functions using proper syntax:
# https://technet.microsoft.com/en-us/library/hh847834(v=wps.620).aspx

$INFRA_CONTAINER = 'gcr.io/gke-release/pause-win:1.1.0'
$INFRA_CONTAINER = 'k8s.gcr.io/pause:3.4.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please let's add this to build/dependencies.yaml in the "dependents" entry so we don't de-sync it again 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, did not follow you, add where? should we remove it from this file? I'm sorry for the dumb question, not clear to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not at all, sorry somehow I thought I'd already seen you interact with this:
https://github.com/kubernetes/kubernetes/blob/473af0b8d1951b5c362df60925bb8d9fb007fab9/build/dependencies.yaml#L162

we have a presubmit that ensures that the versions are in sync based on the (filepath, regex) specs in that file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add these references to the pause image to that list so when pause is updated again someday the presubmit will catch if these new references added in this PR aren't updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL wrong repo. bentheelder is taking a long nap soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wishful thinking. sorry about that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

@BenTheElder
Copy link
Member

/approve
holding LGTM for the nit re build/dependencies.yaml
/sig windows
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2021
@BenTheElder
Copy link
Member

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit ccc309c into kubernetes:master Feb 19, 2021
@cpanato cpanato deleted the K8sio-GH-1525 branch February 20, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@cjcullen cjcullen Awaiting requested review from cjcullen

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@spiffxp spiffxp

@BenTheElder BenTheElder

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cpanato @BenTheElder @k8s-ci-robot @spiffxp @saad-ali @amwat