Remove all GKE specific code from gcp-controller-manager.

[vinayakankugoyal]

No description provided.

[k8s-ci-robot]

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vinayakankugoyal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

/hold

why do we want to do this? I mean, is it safe to do this?

[vinayakankugoyal]

/hold

why do we want to do this? I mean, is it safe to do this?

We deleted gke-exec-auth-plugin from this repo already which is the only thing that could create a CSR that the code that I am deleting could handle. So yes it should be safe.

[aojea]

/hold
why do we want to do this? I mean, is it safe to do this?

We deleted gke-exec-auth-plugin from this repo already which is the only thing that could create a CSR that the code that I am deleting could handle. So yes it should be safe.

/hold cancel

my apologies, I saw the diff that was huge and I was worried 😓

[vinayakankugoyal]

/cc @ahmedtd

[aojea]

@vinayakankugoyal can you please remove the references in the cloud build file too?

cloud-provider-gcp/cloudbuild.yaml

Lines 12 to 23 in 31327cf

	# build gke-exec-auth-plugin binary
	- name: 'gcr.io/cloud-builders/bazel'
	args:
	- --output_user_root=/workspace/bazel-root
	- --output_base=/workspace/bazel-base-linux-amd64
	- build
	- //cmd/gke-exec-auth-plugin
	- name: 'gcr.io/cloud-builders/gsutil'
	args:
	- cp
	- /workspace/bazel-base-linux-amd64/execroot/io_k8s_cloud_provider_gcp/bazel-out/k8-fastbuild/bin/cmd/gke-exec-auth-plugin/gke-exec-auth-plugin_/gke-exec-auth-plugin
	- gs://k8s-staging-cloud-provider-gcp/gke-exec-auth-plugin/linux-amd64/${_GIT_TAG}

cloud-provider-gcp/cloudbuild.yaml

Lines 48 to 60 in 31327cf

	# build gke-exec-auth-plugin binary
	- name: 'gcr.io/cloud-builders/bazel'
	args:
	- --output_user_root=/workspace/bazel-root
	- --output_base=/workspace/bazel-base-linux-arm64
	- build
	- --platforms=@io_bazel_rules_go//go/toolchain:linux_arm64
	- //cmd/gke-exec-auth-plugin
	- name: 'gcr.io/cloud-builders/gsutil'
	args:
	- cp
	- /workspace/bazel-base-linux-arm64/execroot/io_k8s_cloud_provider_gcp/bazel-out/k8-fastbuild/bin/cmd/gke-exec-auth-plugin/gke-exec-auth-plugin_/gke-exec-auth-plugin
	- gs://k8s-staging-cloud-provider-gcp/gke-exec-auth-plugin/linux-arm64/${_GIT_TAG}

[aojea]

/lgtm