Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] Switch CSI sidecar image repository to gcr #1337

Merged
merged 1 commit into from
Dec 8, 2020
Merged

[cinder-csi-plugin] Switch CSI sidecar image repository to gcr #1337

merged 1 commit into from
Dec 8, 2020

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Dec 7, 2020 •
edited by ramineni
Loading

What this PR does / why we need it:
Ref kubernetes-csi/csi-release-tools#86

Release note:

[cinder-csi-plugin] Use GCR images for CSI sidecar containers.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot requested review from adisky and zetaab December 7, 2020 10:40
@ialidzhikov
Switch CSI sidecar image repository to gcr
3889db6 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov
Copy link
Contributor Author

/cc @jichenjc @ramineni

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 7, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 7, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 7, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 7, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 7, 2020

Build succeeded.

@jichenjc
Copy link
Contributor

jichenjc commented Dec 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2020
@gouthampacha
Copy link
Contributor

Hi @ialidzhikov - We've two CSI drivers in this repository, manila-csi being the other one [1][2]; so this change could update both of them at the same time. However, just to be sure - will the CSI container images no longer get published to quay.io? Or is this a temporary change?

[1] https://github.com/kubernetes/cloud-provider-openstack/tree/master/charts/manila-csi-plugin
[2] https://github.com/kubernetes/cloud-provider-openstack/tree/master/manifests/manila-csi-plugin

@ialidzhikov
Copy link
Contributor Author

We've two CSI drivers in this repository, manila-csi being the other one [1][2]; so this change could update both of them at the same time

Currently one of the sidecar images for manilla-csi (I think it was the external-provisioner image) is outdated and this version is only available in quay. If you don't have objections I can file a separate PR for manilla-csi as I will need also to update the version of the sidecar container.

However, just to be sure - will the CSI container images no longer get published to quay.io? Or is this a temporary change?

As stated in kubernetes-csi/csi-release-tools#86 (comment), my understanding is that the push to quay will be dropped at some point in the time. For now I see that the recent images are also pushed to quay (probably for backwards compatibility reasons) but I think that soon the sidecar images will be maintained only in gcr. You can also see that the advertised images in the README.mds or in the releases are the gcr ones. @msau42 , @pohly feel free to add more details or correct me if I am wrong. : )

@gouthampacha
Copy link
Contributor

We've two CSI drivers in this repository, manila-csi being the other one [1][2]; so this change could update both of them at the same time

Currently one of the sidecar images for manilla-csi (I think it was the external-provisioner image) is outdated and this version is only available in quay. If you don't have objections I can file a separate PR for manilla-csi as I will need also to update the version of the sidecar container.

That would be great - I've no objections. Thank you for submitting this change, @ialidzhikov

/cc @gman0 @tombarron

jichenjc
jichenjc reviewed Dec 8, 2020
View reviewed changes
charts/cinder-csi-plugin/values.yaml
tag: v2.2.1
pullPolicy: IfNotPresent
provisioner:
image:
repository: quay.io/k8scsi/csi-provisioner
repository: k8s.gcr.io/sig-storage/csi-provisioner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works

# docker pull k8s.gcr.io/sig-storage/csi-provisioner:v1.6.1
v1.6.1: Pulling from sig-storage/csi-provisioner
Digest: sha256:3b9b5ae677fd74de3b1cde5d3606a970f615b598730aa003c0f52e755c78862e
Status: Downloaded newer image for k8s.gcr.io/sig-storage/csi-provisioner:v1.6.1
k8s.gcr.io/sig-storage/csi-provisioner:v1.6.1

@jichenjc
Copy link
Contributor

jichenjc commented Dec 8, 2020

just curious , should we update the release notes about the image modification ? @ialidzhikov

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2020
@ialidzhikov
Copy link
Contributor Author

just curious , should we update the release notes about the image modification ? @ialidzhikov

I added a release note.

@ramineni
Copy link
Contributor

ramineni commented Dec 8, 2020

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2020
@jichenjc
Copy link
Contributor

jichenjc commented Dec 8, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 67b5b17 into kubernetes:master Dec 8, 2020
@ialidzhikov ialidzhikov deleted the enh/pull-from-gcr branch December 8, 2020 08:39
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@ialidzhikov
Switch CSI sidecar image repository to gcr (kubernetes#1337)
5cd19a7 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc jichenjc left review comments

@adisky adisky Awaiting requested review from adisky

@zetaab zetaab Awaiting requested review from zetaab

@ramineni ramineni Awaiting requested review from ramineni

@gman0 gman0 Awaiting requested review from gman0

@tombarron tombarron Awaiting requested review from tombarron

Assignees

@ramineni ramineni

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @k8s-ci-robot @jichenjc @gouthampacha @ramineni