Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[occm] Revert dnsPolicy to Default for occm #2621

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Jul 2, 2024

What this PR does / why we need it: reverts the behaviour that was added #2594

Which issue this PR fixes(if applicable):
fixes #2611

Special notes for reviewers:
if dnsPolicy is defined the default value is not Default its ClusterFirst. See https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2024
@zetaab
Copy link
Member Author

zetaab commented Jul 2, 2024

cc @mdbooth @jichenjc

@zetaab
Copy link
Member Author

zetaab commented Jul 2, 2024

/test openstack-cloud-controller-manager-e2e-test
/test openstack-cloud-controller-manager-ovn-e2e-test

@zetaab
Copy link
Member Author

zetaab commented Jul 2, 2024

/test pull-cloud-provider-openstack-check

@zetaab zetaab closed this Jul 2, 2024
@zetaab zetaab reopened this Jul 2, 2024
@jichenjc
Copy link
Contributor

jichenjc commented Jul 3, 2024

/test openstack-cloud-controller-manager-e2e-test
/test openstack-cloud-controller-manager-ovn-e2e-test

@jichenjc
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit e39dffb into kubernetes:master Jul 12, 2024
8 checks passed
@zetaab zetaab deleted the fixcii branch July 13, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[occm] dnsPolicy default value recent change blocks occm / cluster from coming up.
3 participants