Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GetLabelsForVolume to handle only Cinder volumes #342

Merged
merged 1 commit into from
Nov 11, 2018
Merged

fix GetLabelsForVolume to handle only Cinder volumes #342

merged 1 commit into from
Nov 11, 2018

Conversation

mvladev
Copy link
Contributor

@mvladev mvladev commented Oct 31, 2018

What this PR does / why we need it:
When the openstack-cloud-controller-manager is running with PV label initializing controller
and NFS volume is created, it causes nill reference error.

Which issue this PR fixes
OpenStack version of kubernetes/kubernetes#68996

Special notes for your reviewer:
This is a cherry-pick of kubernetes/kubernetes#70459

Release note:

NONE

fix GetLabelsForVolume to handle only Cinder volumes
a3da939 
When the openstack-cloud-controller-manager is running with PV label initializing controller
and NFS volume is created, it causes nill reference error.
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2018
@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@adisky
Copy link
Contributor

adisky commented Oct 31, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2018
@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@adisky
Copy link
Contributor

adisky commented Oct 31, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@NickrenREN
Copy link
Contributor

/lgtm
/approve

thanks @mvladev

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@NickrenREN
Copy link
Contributor

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

@NickrenREN
Copy link
Contributor

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@mvladev
Copy link
Contributor Author

mvladev commented Nov 1, 2018

@NickrenREN is this cloud-provider-openstack-acceptance-test-flexvolume-cinder a flanky test? I don't think that this PR can affect it.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 1, 2018

Build succeeded.

@dims
Copy link
Member

dims commented Nov 5, 2018

/lgtm
/approve

/override "openlab/cloud-provider-openstack-acceptance-test-flexvolume-cinder"

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, NickrenREN

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Nov 11, 2018

/override openlab/cloud-provider-openstack-acceptance-test-flexvolume-cinder

@k8s-ci-robot
Copy link
Contributor

@dims: Overrode contexts on behalf of dims: openlab/cloud-provider-openstack-acceptance-test-flexvolume-cinder

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-flexvolume-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 4612e40 into kubernetes:master Nov 11, 2018
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@k8s-ci-robot
Merge pull request kubernetes#342 from mvladev/fix-GetLabelsForVolume…
1f196f9 
…-nil-dereference

fix GetLabelsForVolume to handle only Cinder volumes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@NickrenREN NickrenREN Awaiting requested review from NickrenREN

Assignees

@dims dims

@NickrenREN NickrenREN

@adisky adisky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mvladev @adisky @NickrenREN @dims @k8s-ci-robot