-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix GetLabelsForVolume to handle only Cinder volumes #342
fix GetLabelsForVolume to handle only Cinder volumes #342
Conversation
When the openstack-cloud-controller-manager is running with PV label initializing controller and NFS volume is created, it causes nill reference error.
Build succeeded.
|
/ok-to-test |
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Build failed.
|
Build succeeded.
|
/lgtm |
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
/lgtm thanks @mvladev |
/retest |
Build succeeded.
|
/retest |
Build succeeded.
|
Build succeeded.
|
Build failed.
|
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
@NickrenREN is this |
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
/lgtm /override "openlab/cloud-provider-openstack-acceptance-test-flexvolume-cinder" |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, NickrenREN The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override openlab/cloud-provider-openstack-acceptance-test-flexvolume-cinder |
@dims: Overrode contexts on behalf of dims: openlab/cloud-provider-openstack-acceptance-test-flexvolume-cinder In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…-nil-dereference fix GetLabelsForVolume to handle only Cinder volumes
What this PR does / why we need it:
When the
openstack-cloud-controller-manager
is running with PV label initializing controllerand NFS volume is created, it causes nill reference error.
Which issue this PR fixes
OpenStack
version of kubernetes/kubernetes#68996Special notes for your reviewer:
This is a cherry-pick of kubernetes/kubernetes#70459
Release note: