-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate json-schema from go types #28
Comments
Yep - likely I won't have a chance to get onto this until next week, as this is my final week before xmas. I think @sttts and I discussed initially adding an 'output format' parameter to openapi-gen in order to facilitate this. |
/assign |
+1 to this. I'm looking into having the cluster registry be a CRD and this would be a boon for that. |
kubernetes/kube-openapi#37 needs review time. |
I’m happy to follow up with additional features (such as comments tags to
allow specifying regex’s to validate with, etc) once the structure/design
is accepted too.
I just didn’t want to rush ahead and introduce a load of new functionality
without being sure that the way it’s implemented makes sense!
…On Thu, 8 Mar 2018 at 07:31, Dr. Stefan Schimanski ***@***.***> wrote:
kubernetes/kube-openapi#37
<kubernetes/kube-openapi#37> needs review time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMbP-0p3ZXuuHRFBGV3uXD42qCST1Efks5tcN5jgaJpZM4Q-YKH>
.
|
I just came across this which looks similar: |
I expect we will take this on in kube-openapi and not here. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/lifecycle frozen
…On Tue, Oct 9, 2018 at 11:52 PM fejta-bot ***@***.***> wrote:
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta
<https://github.com/fejta>.
/lifecycle rotten
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0B2EtSWfjmfM0G2tSme-gH3-22mFks5ujOlNgaJpZM4Q-YKH>
.
|
/unassign mbohlool |
Work on this is going on in http://github.com/kubernetes-sigs/controller-tools. |
/close stale? |
@thockin: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When you create a CRD, it can have a schema defined using json-schema.
In github.com/kubernetes/sample-controller the client libraries for a controller are generated from a go API definition, and CRDs are created, but there is no schema for the CRD, which means less validation.
It would be nice to generate the json-schema for the CRD from the Go types. So, this is proposing a new generator that generates json-schema for CRDs from go types.
The text was updated successfully, but these errors were encountered: