-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change set-gen to respect command-line arguments like input and output directory #74
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen Another instance where set-gen would have been useful in a sigs project: kubernetes-sigs/cluster-api#2193 |
@dlipovetsky: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
/lifecycle frozen |
/close |
@thockin: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
set-gen overrides command-line arguments such as input and output directory. As a consequence, set-gen can only generate code for the types listed in the
k8s.io/kubernetes/pkg/util/sets/types
package.Some SIG subprojects (e.g. https://github.com/kubernetes-sigs/cluster-api/) have types that could benefit from the set implementation set-gen can generate.
For example, kubernetes-sigs/cluster-api-provider-aws#881 would have been unnecessary if the set implementation were available for the APIEndpoints type.
/cc @vincepri
The text was updated successfully, but these errors were encountered: