Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api-conventions.md should explain patchStrategy #3752

Open
MikeSpreitzer opened this issue May 31, 2019 · 20 comments
Open

api-conventions.md should explain patchStrategy #3752

MikeSpreitzer opened this issue May 31, 2019 · 20 comments
Assignees
@apelisse @MikeSpreitzer
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Milestone
Next

Comments

@MikeSpreitzer
Copy link
Member

The API conventions doc should explain, or point to an explanation of, the patchStrategy stuff that appears in golang. The reader should be told how to understand the existing golang, and how to use patchStrategy when writing new golang. This should include a pointer to the definitions of what each patchStrategy means.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2019
@MikeSpreitzer
Copy link
Member Author

@kubernetes/sig-api-machinery-misc

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 31, 2019
@nikhita
Copy link
Member

nikhita commented Jun 2, 2019

Adding sig-arch as well because they own the doc
/sig architecture
/kind documentation

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. kind/documentation Categorizes issue or PR as related to documentation. labels Jun 2, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 31, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 30, 2019
@MikeSpreitzer
Copy link
Member Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 28, 2019
@apelisse apelisse mentioned this issue Oct 28, 2019
Open
@mariantalla mariantalla mentioned this issue Nov 5, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2020
@MikeSpreitzer
Copy link
Member Author

/remove-lifecycle stale
still current, see #87594

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2020
@lavalamp
Copy link
Member

/assign @apelisse

@lavalamp
Copy link
Member

Since we should also explain the new way.

@apelisse
Copy link
Member

Should be fixed by #4218

@mrbobbytables mrbobbytables added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Mar 11, 2020
@mrbobbytables mrbobbytables added this to the Next milestone Mar 11, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 9, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 9, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lavalamp
Copy link
Member

/reopen
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot reopened this Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

@lavalamp: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 10, 2020
@mrbobbytables mrbobbytables mentioned this issue Oct 16, 2020
Closed
@fedebongio
Copy link
Contributor

/assign @apelisse @MikeSpreitzer

@thockin
Copy link
Member

thockin commented Mar 30, 2022

+100000

@lavalamp
Copy link
Member

Note that we should also recommend the newer SSA version of these concepts.

I don't know if we can realistically get rid of SMP, or even officially deprecate it, at least not soon -- but it has bugs we don't intend to fix.

@thockin
Copy link
Member

thockin commented Mar 30, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apelisse apelisse

@MikeSpreitzer MikeSpreitzer

Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
WG/API-Expressions - Server Side Apply and OpenAPIv3
Status: Backlog Authoring Controllers SSA
Milestone
Next
Development

No branches or pull requests
9 participants
@lavalamp @apelisse @fedebongio @thockin @mrbobbytables @MikeSpreitzer @nikhita @k8s-ci-robot @fejta-bot