-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links after design proposals move #1128
Fix links after design proposals move #1128
Conversation
I am not sure about this but noticed that some proposals (example) have the Anayltics link as:
Should this link also be updated? |
AFAICT, the code that generated that munge has been deleted. I suspect we might even be able to get rid of the links entirely? Does someone from @kubernetes/sig-docs-maintainers know the state of our google analytics usage? I'm not sure it even applies to .md files in github repos. A glance through kubernetes/* and kubernetes-incubator/* shows many outdated links (eg: the code-of-conduct.md links) |
@spiffxp 👋 I can't speak to site analytics per se, and it may be unrelated to the matter at hand, but here's what the search console shows for 404s from links with |
I'm checking into this. I'll reply later this afternoon.
…On Thu, Oct 5, 2017 at 1:17 PM, Zach Corleissen ***@***.***> wrote:
@spiffxp <https://github.com/spiffxp> 👋 I can't speak to site analytics *per
se*, and it may be unrelated to the matter at hand, but here's what the
search console shows for 404s from links with *.md in the past 30 days:
[image: screen shot 2017-10-05 at 3 12 26 pm]
<https://user-images.githubusercontent.com/3210446/31250304-0a63d5f8-a9e0-11e7-8d4d-6d9264f2d981.png>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#1128 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANJ2Diu439z7l0kAfA8eZQ0YXgprYSKjks5spTljgaJpZM4PjUdC>
.
|
Signed in as stevepe@google.com, at https://analytics.google.com, I can see
the Kubernetes Google Analytics account. I have limited access (Read and
Analyze).
Nate Kartchner, at the Linux Foundation, is a manager for the Kubernetes GA
account. If you would like to be a member of the Kubernetes Google
Analytics account, send mail directly to nkartchner@linuxfoundation.org.
Account: Kubernetes
Property: Kubernetes
Views:
PROD: Kuberbetes Github
PROD: Kubernetes.io (This is the one we use for the doc set at
kubernetes.io.)
PROD: RAW: Kubernetes
Here are my notes from the past, but they don't seem to be true any more.
So at this point I don't understand what we get from PROD: Kubernetes
Github and PROD: RAW: Kubernetes.
PROD: RAW: Kubernetes has no filters. It counts both internal and external
traffic. It counts visits to both kubernetes.io and github.com/kubernetes.
PROD: Kubernetes.io filters out visits from internal IP addresses. And it
counts only visits to kubernetes.io.
PROD: Kubernetes Github filters out visits from internal IP addresses. And
it counts only visits to github.com/kubernetes
…On Thu, Oct 5, 2017 at 3:19 PM, Steve Perry ***@***.***> wrote:
I'm checking into this. I'll reply later this afternoon.
On Thu, Oct 5, 2017 at 1:17 PM, Zach Corleissen ***@***.***>
wrote:
> @spiffxp <https://github.com/spiffxp> 👋 I can't speak to site analytics *per
> se*, and it may be unrelated to the matter at hand, but here's what the
> search console shows for 404s from links with *.md in the past 30 days:
>
> [image: screen shot 2017-10-05 at 3 12 26 pm]
> <https://user-images.githubusercontent.com/3210446/31250304-0a63d5f8-a9e0-11e7-8d4d-6d9264f2d981.png>
>
> —
> You are receiving this because you are on a team that was mentioned.
> Reply to this email directly, view it on GitHub
> <#1128 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANJ2Diu439z7l0kAfA8eZQ0YXgprYSKjks5spTljgaJpZM4PjUdC>
> .
>
|
/lgtm The current changes look good. We can fix the analytics links in another PR. |
Automatic merge from submit-queue. |
Automatic merge from submit-queue. Fix links after design proposals move Some links broke when design proposals were organized in kubernetes#1010. They were mostly fixed in kubernetes#1116 but a few seem to still be pointing to the old ones. Takes another stab at kubernetes#1109. /cc @grodrigues3
Some links broke when design proposals were organized in #1010. They were mostly fixed in #1116 but a few seem to still be pointing to the old ones.
Takes another stab at #1109.
/cc @grodrigues3