Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-auth: add HNC subproject #5550

Merged
merged 1 commit into from
Mar 23, 2021
Merged

sig-auth: add HNC subproject #5550

merged 1 commit into from
Mar 23, 2021

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Feb 24, 2021

Fixes kubernetes/org#2516

/assign @mikedanese

/hold
for lgtm from sig-auth leads

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from enj and liggitt February 24, 2021 11:46
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
@nikhita nikhita mentioned this pull request Feb 24, 2021
Closed
@nikhita
Copy link
Member Author

nikhita commented Mar 7, 2021

@mikedanese friendly ping on this :)

@spiffxp
Copy link
Member

spiffxp commented Mar 10, 2021

needs rebase

@mikedanese
Copy link
Member

Sorry for the delay.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 10, 2021
@nikhita nikhita force-pushed the hierarchical-namespaces branch from 1376134 to f44ffec Compare March 23, 2021 03:30
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 23, 2021
@nikhita
Copy link
Member Author

nikhita commented Mar 23, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@Pensu
Copy link
Contributor

Pensu commented Mar 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit df6f4fd into kubernetes:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@mikedanese mikedanese

@Pensu Pensu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New repository for hierarchical-namespaces under kubernetes-sigs
5 participants
@nikhita @k8s-ci-robot @spiffxp @mikedanese @Pensu