-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: SIG Docs 2020 Annual Report #5569
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irvifa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sig-docs/annual-report-2021.md
Outdated
**How does the group get updates, reports, or feedback from Working Groups? Are there any springing up or being retired? | ||
Are OWNERS files up to date in these areas?** | ||
|
||
<!-- TODO --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim Once we have the thought of doing clean up of approver that's not active anymore on the shift, is this already done? Any specific procedure that we need to share?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we decided that OWNER files are up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it thanks 👍
|
||
<!-- TODO --> | ||
|
||
**When was your last monthly community-wide update? (provide link to deck and/or recording)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimangel Would you mind filling this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall which community meeting this was done in, but guessing Q2 of 2020 (created April 8 2020)? https://docs.google.com/presentation/d/12WnYz8SbjWRZbK4k2qlc1Ab7Z-f2F7kk-Tb2eRTfTy8/edit?usp=sharing
sig-docs/annual-report-2021.md
Outdated
|
||
**Year to date KEP work review: What’s now stable? Beta? Alpha? Road to alpha?** | ||
|
||
<!-- TODO --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one I don't think we have this, please correct me if I'm wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the third part content removal is a kep, https://github.com/kubernetes/enhancements/tree/master/keps/sig-docs/1326-third-party-content-in-docs. but i'm not sure of the current state or if there is anything to report in this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup for that is in progress, it's an ongoing process that doesn't target a specific release.
We could report on PRs linked to the umbrella issue if we want to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be beneficial to link to the umbrella issue then, do you have the link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sig-docs/annual-report-2021.md
Outdated
|
||
**What's the average open days of a PR and Issue in your group? / what metrics does your group care about and/or measure?** | ||
|
||
<!-- TODO --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have something that can be used to track how many Issues and PR that available in general per day?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://k8s.devstats.cncf.io/ is useful here
We usually look at total open PRs, total open issues (both for k/website specifically), and total open PRs labelled “language/en”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put the graph and the link to the graph, PTAL
sig-docs/annual-report-2021.md
Outdated
What are some activities that the group does to encourage this? | ||
What programs are you participating in to grow contributors throughout the contributor ladder?** | ||
|
||
There is no official onboarding process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional:
I would add that the SIG is supportive of new contributors, willing to walk through the contribution process and eager
to see contributions completed. Issues are created regularly and triaged. Issues are also created specifically for new contributors. There are issues labelled for the different contribution areas (web development, blog, first time contributors, task, concept, API, ...) which helps new contributors identify how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I added it on the docs, thank you 👍
06e140e
to
4d7d156
Compare
4d7d156
to
b25aedf
Compare
**How does the group get updates, reports, or feedback from subprojects? Are there any springing up or being retired? | ||
Are OWNERS files up to date in these areas?** | ||
|
||
Yes it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does the group get updates from the subprojects? do you have that included in standup at the meeting? or some other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any new subprojects in the last year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if the localization one is actually a subproject @bradtopol I remember that this was founded last year
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subproject teams provide project updates at the SIG quarterly meetings or discuss changes at the weekly meetings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the localization project is considered a subproject (maintains separate meetings like the Blog subproject).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it really depends on the long term goal. I know when the localization group was created, the intention was to unify all localization efforts and dissolve (making it a working group). However, I do see value in it continuing permanently as long as there's contributor support.
My "gut feeling" is that the localization group started as a WG and probably should be considered a subproject now. At the very least, it's worth calling out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the very least, it's worth calling out here.
+1
sig-docs/annual-report-2021.md
Outdated
In general each of the approver will taking the rotation. Under exceptional circumstances where there's lots of | ||
pressure for the wrangler, another approver usually will be willing to help. | ||
|
||
For technical reviews, other than SIG Docs Tech Leads, we also notify respective SIGs with necessary knowledge of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need help in this area?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I need help on this area
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does SIG Docs need help with reviewer and approver bandwidth?
My gut feeling is that we don't have good enough measurements on that / aren't looking at the measurements enough to know. It sounds like we're missing a check, but if that's the accurate story then we should say so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have measured the types of contributions identified by SIG, per PR.
Could add something like:
SIG Docs receives contributions from community members representing different SIGs.
During the PR review process, SIG Docs reaches out to other SIGs when a pull request requires technical review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts
sig-docs/annual-report-2021.md
Outdated
In general each of the approver will taking the rotation. Under exceptional circumstances where there's lots of | ||
pressure for the wrangler, another approver usually will be willing to help. | ||
|
||
For technical reviews, other than SIG Docs Tech Leads, we also notify respective SIGs with necessary knowledge of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does SIG Docs need help with reviewer and approver bandwidth?
My gut feeling is that we don't have good enough measurements on that / aren't looking at the measurements enough to know. It sounds like we're missing a check, but if that's the accurate story then we should say so.
sig-docs/annual-report-2021.md
Outdated
**How does the group measure reviewer and approver bandwidth? Do you need help in any area now? What are you doing about it?** | ||
|
||
PR are generally open for anyone to review. We have [PR wrangler rotation](https://github.com/kubernetes/website/wiki/PR-Wranglers). | ||
In general each of the approver will taking the rotation. Under exceptional circumstances where there's lots of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think line 60 (and the included link) explains the PR rotation. I would rewrite lines 61-62 as:
Each approver participates in the PR wrangler rotation. Approvers are supported during their rotation by other reviewers and approvers.
Add some input from the others.
/committee steering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my delay, let some minor nits and comments. Great work @irvifa! Thanks for getting this started!
|
||
<!-- TODO --> | ||
|
||
**When was your last monthly community-wide update? (provide link to deck and/or recording)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall which community meeting this was done in, but guessing Q2 of 2020 (created April 8 2020)? https://docs.google.com/presentation/d/12WnYz8SbjWRZbK4k2qlc1Ab7Z-f2F7kk-Tb2eRTfTy8/edit?usp=sharing
**How does the group get updates, reports, or feedback from subprojects? Are there any springing up or being retired? | ||
Are OWNERS files up to date in these areas?** | ||
|
||
Yes it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it really depends on the long term goal. I know when the localization group was created, the intention was to unify all localization efforts and dissolve (making it a working group). However, I do see value in it continuing permanently as long as there's contributor support.
My "gut feeling" is that the localization group started as a WG and probably should be considered a subproject now. At the very least, it's worth calling out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added suggestions from Jim as well in my latest commit. NP just glad I can help somehow.
b09a903
to
e8c082a
Compare
We have the information from [devstat](https://k8s.devstats.cncf.io/d/25/open-pr-age-by-repository-group?orgId=1&var-period=q&var-repogroup_name=SIG%20Docs&var-kind_name=All): | ||
|
||
![Devstat 2020](devstats/devstats-quarter-2021.png) | ||
|
||
For example, based on 10/01/2020 data, we have: | ||
Average number of opened PRs 1.23 K with the median opened PRs age 3 days 13 hours 52 minutes 10 seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add that we informally review metrics quarterly. Also ad hoc if anyone brings it up at a weekly meeting.
We aim to have < 100 open PRs for the English localization, and will take steps as needed if we see the figure climbing much above that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a nice goal / ballpark benchmark to call out
looks like there were a couple outstanding suggestions to fold in, then looks good to me |
any other last suggestions from any other reviewers? |
No further questions your worships. |
Co-authored-by: Jim Angel <jimangel@users.noreply.github.com>
e8c082a
to
25ad775
Compare
Hi all, I just added the last few comments on the PR, kindly check and let me know if there's something left. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/lgtm
/merge-method squash |
Currently just the annual report template.
Requested in #5503.
Co-author:
/assign @irvifa @jimangel @kbarnard10
Steering liaison:
/assign @liggitt
SIG Docs leads: @kubernetes/sig-docs-leads
Fixes #5503