-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token file reload to client library requirements #5580
Conversation
@liggitt: Adding label: Reasons for blocking this PR:[The Design Proposal process has been deprecated in favor of Kubernetes Enhancement Proposals (KEP). These documents are here for historical purposes only.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
huh... is there a replacement location for this doc I'm missing? |
/lgtm |
@liggitt Theres a blockade rule for all of design-proposals as they've been deprecated and replaced by KEPs. Ideally information from there gets integrated into various documentation in the devel directory. |
I'd like to override the blockade for this update, since this file is still getting actively referenced for new clients (xref https://groups.google.com/g/kubernetes-sig-api-machinery/c/9TT-7_WMPCE/m/GV3VJNluBQAJ) follow up to move it to a more visible / current location seems good as well. |
Done 👍 |
Is the reloading actually implemented in client-go? The rest.InClusterConfig() which is referenced from some |
yes, it plumbs both the value read and BearerTokenFile into the resulting config. When BearerTokenFile is set, it drives reloading behavior |
Which issue(s) this PR fixes:
Fixes kubernetes/kubernetes#68164
Status of existing client libraries applying this change:
/cc @mikedanese @zshihang @deads2k @lavalamp