Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token file reload to client library requirements #5580

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

@k8s-ci-robot
Copy link
Contributor

@liggitt: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[The Design Proposal process has been deprecated in favor of Kubernetes Enhancement Proposals (KEP). These documents are here for historical purposes only.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/design Categorizes issue or PR as related to design. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2021
@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2021

huh... is there a replacement location for this doc I'm missing?

@zshihang
Copy link

zshihang commented Mar 1, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@mrbobbytables
Copy link
Member

@liggitt Theres a blockade rule for all of design-proposals as they've been deprecated and replaced by KEPs. Ideally information from there gets integrated into various documentation in the devel directory.

@liggitt
Copy link
Member Author

liggitt commented Mar 6, 2021

I'd like to override the blockade for this update, since this file is still getting actively referenced for new clients (xref https://groups.google.com/g/kubernetes-sig-api-machinery/c/9TT-7_WMPCE/m/GV3VJNluBQAJ)

follow up to move it to a more visible / current location seems good as well.

@mrbobbytables mrbobbytables removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 6, 2021
@mrbobbytables
Copy link
Member

Done 👍

@k8s-ci-robot k8s-ci-robot merged commit 39d25a2 into kubernetes:master Mar 6, 2021
@liggitt liggitt deleted the reload-token branch March 6, 2021 21:08
@ahmetb
Copy link
Member

ahmetb commented Sep 28, 2022

Is the reloading actually implemented in client-go? The rest.InClusterConfig() which is referenced from some client-go/examples seems to be still reading the token file only once.

@liggitt
Copy link
Member Author

liggitt commented Sep 28, 2022

Is the reloading actually implemented in client-go? The rest.InClusterConfig() which is referenced from some client-go/examples seems to be still reading the token file only once.

yes, it plumbs both the value read and BearerTokenFile into the resulting config. When BearerTokenFile is set, it drives reloading behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update client client guidelines to recommend reloading tokens
5 participants