Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIG Instrumentation annual report, 2021 #5603

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Mar 6, 2021

Which issue(s) this PR fixes:

Fixes #5504.

/hold
for discussion

/sig instrumentation
/cc @kubernetes/sig-instrumentation-members

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2021
Comment on lines 69 to 70
* Structured Logging
* Promtool
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logicalhan can we add a link for promtool? not sure what it is, structured logging is linked above

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think she was referring (?) to promq, which is something we wrote.

https://github.com/kubernetes-sigs/instrumentation-tools

(Sorry have been OOO)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehashman
Copy link
Member Author

ehashman commented Mar 6, 2021

/cc @cblecker
instrumentation steering liaison

@dashpole
Copy link
Contributor

dashpole commented Mar 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2021
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2021
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

🎉 Thanks for taking care of this!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, lilic, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehashman
Copy link
Member Author

I will remove the hold on Friday, Mar. 19 after a week of lazy consensus if no further comments.

@serathius
Copy link
Contributor

@dgrisonnet @s-urbaniak Should we also mention work on Metrics Server and prometheus adapter ?

@dgrisonnet
Copy link
Member

👍 sounds like a good idea, I can prepare something for prometheus-adapter.

@ehashman
Copy link
Member Author

Please each give me a one line blurb + link :)

@lilic
Copy link
Member

lilic commented Mar 16, 2021

@brancz can suggest otherwise.

@s-urbaniak
Copy link
Contributor

agreed on adding a line about prometheus-adapter, metrics-server, maybe even custom-metrics-apiserver 👍

@dgrisonnet
Copy link
Member

Here are some suggestions for custom-metrics-apiserver and prometheus-adapter, let me know if it's fine with you.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@ehashman
Copy link
Member Author

Added subproject updates.

/hold cancel

LGTM at will :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@logicalhan
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit d89e944 into kubernetes:master Mar 24, 2021
@cblecker
Copy link
Member

retroactive LGTM

Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retroactive lgtm. Just left one question, but it's probably me missing something here :)

* We have lively biweekly regular meetings and biweekly triage sessions. Our recordings are relatively up to date and we receive requests for them so we believe they are being watched. Our community archives are all up to date.
* How does the group get updates, reports, or feedback from subprojects? Are there any springing up or being retired? Are OWNERS files up to date in these areas?
* We request these in SIG meetings and asynchronously for KubeCon and other community updates.
* See above for OWNERS updates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something here...can you point me to the process for keeping OWNERS up to date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there were a bunch of scratch notes that didn't make it in here. This was referring to https://github.com/kubernetes/community/pull/5603/files#diff-c7b01de0190da099e3c4819f213c78276bb6514a43f9f51339277f65c7ee7b29R10-R11

When we went through reviewing our charter and subprojects, we also reviewed all our OWNERS files, which are mainly in subprojects as we only own a small portion of k/k.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +35 to +36
* We would like to grow more contributors into SIG leadership roles for sustainability.
* We invite newbies to come to triage meetings to learn how to review and triage code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this

@dims
Copy link
Member

dims commented Apr 9, 2021

/committee steering

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2021 Annual Report: SIG Instrumentation