-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SIG Instrumentation annual report, 2021 #5603
Conversation
* Structured Logging | ||
* Promtool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@logicalhan can we add a link for promtool? not sure what it is, structured logging is linked above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should help https://github.com/prometheus/prometheus/tree/main/cmd/promtool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think she was referring (?) to promq, which is something we wrote.
https://github.com/kubernetes-sigs/instrumentation-tools
(Sorry have been OOO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @cblecker |
/lgtm |
2af5395
to
c00788d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
🎉 Thanks for taking care of this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, lilic, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I will remove the hold on Friday, Mar. 19 after a week of lazy consensus if no further comments. |
@dgrisonnet @s-urbaniak Should we also mention work on Metrics Server and prometheus adapter ? |
👍 sounds like a good idea, I can prepare something for prometheus-adapter. |
Please each give me a one line blurb + link :) |
@brancz can suggest otherwise. |
agreed on adding a line about prometheus-adapter, metrics-server, maybe even custom-metrics-apiserver 👍 |
Here are some suggestions for custom-metrics-apiserver and prometheus-adapter, let me know if it's fine with you. |
c00788d
to
69a8ad9
Compare
Added subproject updates. /hold cancel LGTM at will :) |
/lgtm |
retroactive LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retroactive lgtm. Just left one question, but it's probably me missing something here :)
* We have lively biweekly regular meetings and biweekly triage sessions. Our recordings are relatively up to date and we receive requests for them so we believe they are being watched. Our community archives are all up to date. | ||
* How does the group get updates, reports, or feedback from subprojects? Are there any springing up or being retired? Are OWNERS files up to date in these areas? | ||
* We request these in SIG meetings and asynchronously for KubeCon and other community updates. | ||
* See above for OWNERS updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm probably missing something here...can you point me to the process for keeping OWNERS up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, there were a bunch of scratch notes that didn't make it in here. This was referring to https://github.com/kubernetes/community/pull/5603/files#diff-c7b01de0190da099e3c4819f213c78276bb6514a43f9f51339277f65c7ee7b29R10-R11
When we went through reviewing our charter and subprojects, we also reviewed all our OWNERS files, which are mainly in subprojects as we only own a small portion of k/k.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates were kubernetes/kubernetes#99013 and kubernetes/org#2497 kubernetes/org#2541
* We would like to grow more contributors into SIG leadership roles for sustainability. | ||
* We invite newbies to come to triage meetings to learn how to review and triage code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ this
/committee steering |
Which issue(s) this PR fixes:
Fixes #5504.
/hold
for discussion
/sig instrumentation
/cc @kubernetes/sig-instrumentation-members