Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sig-security-assessments sub-project #6512

Closed
wants to merge 1 commit into from
Closed

Add sig-security-assessments sub-project #6512

wants to merge 1 commit into from

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Mar 2, 2022 •
edited
Loading

Sub-project has now been identified: kubernetes/sig-security#48

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Mar 2, 2022
@PushkarJ PushkarJ mentioned this pull request Mar 2, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 31, 2022
@PushkarJ PushkarJ marked this pull request as ready for review June 16, 2022 04:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2022
@PushkarJ
Copy link
Member Author

/unhold

(kubernetes/sig-security#48 is merged)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2022
@PushkarJ
Copy link
Member Author

/cc @aladewberry please take a look and if all looks good please comment with /lgtm

@PushkarJ
Copy link
Member Author

/remove-lifecycle stale
/cc aladewberry

@k8s-ci-robot k8s-ci-robot requested a review from aladewberry June 16, 2022 04:36
@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 16, 2022
@aladewberry
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@aladewberry
Copy link
Contributor

Yay! Thank you everyone for your help!!!

@PushkarJ
Copy link
Member Author

/assign tabbysable iancoldwater

(For /approve to officially make an entry about this subproject in k/community)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aladewberry, PushkarJ
To complete the pull request process, please assign dims after the PR has been reviewed.
You can assign the PR to them by writing /assign @dims in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aladewberry
Copy link
Contributor

/assign @dims

tabbysable
tabbysable reviewed Jun 17, 2022
View reviewed changes
sig-security/README.md
- **Owners:**
- [kubernetes/sig-security/sig-security-assessments](https://github.com/kubernetes/sig-security/blob/main/sig-security-assessments/OWNERS)
- **Contact:**
- Slack: [#sig-security-assess-capi](https://kubernetes.slack.com/messages/sig-security-assess-capi)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it's tying the subproject pretty closely to the history of the CAPI assessment; WDYT about creating a new slack channel for a fresh history and more general focus?.

As we figure out the long-term workflows for self-assessments we can come back and update things as necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also +1 avoid tying it directly to capi. If the channel has the right folk in it, could just rename it to be more generic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tabbysable and @mrbobbytables ! I'll have a look at the slack channel to see its content. If it's general enough, I'll plan to rename. Otherwise I'll make a new one.

If I were to rename the channel, is there a process I need to go through for doing that? Or just rename it and submit a PR to update the README?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, new channel (#sig-security-assessments) makes sense since the discussion in current channel was very specific to Cluster API.

That channel can act as root node of security assessments sub-project (from thought exercise perspective) that can branch out to new channels that are project specific. e.g.

sig-security
- sig-security-assessments
-- sig-security-assess-capi
-- sig-security-assess-csi-driver

If we decide to go this route,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - I came to the same conclusion reading the channel on Friday - new channel for the root node! Do I need to get any further approval to go ahead and request the new channel, or just have at it and get it stood up?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requested a new channel! #6722

@aladewberry aladewberry mentioned this pull request Jun 29, 2022
Closed
@dims
Copy link
Member

dims commented Jul 31, 2022

@PushkarJ please let me know when this is ready

@dims dims removed their assignment Aug 9, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2022
@PushkarJ
Copy link
Member Author

/remove-lifecycle stale

(Will update channel name soon)

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2023
@aladewberry
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2023
@tabbysable tabbysable mentioned this pull request Mar 28, 2023
Merged
@tabbysable
Copy link
Member

/hold We can close this once #7221 merges, it's functionally a duplicate.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PushkarJ
Copy link
Member Author

Since #7221 has merged

/close

@k8s-ci-robot
Copy link
Contributor

@PushkarJ: Closed this PR.

In response to this:

Since #7221 has merged

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables mrbobbytables left review comments

@tabbysable tabbysable tabbysable left review comments

@aladewberry aladewberry aladewberry approved these changes

@IanColdwater IanColdwater Awaiting requested review from IanColdwater

Assignees

@IanColdwater IanColdwater

@tabbysable tabbysable

@aladewberry aladewberry

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/security Categorizes an issue or PR as relevant to SIG Security. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@PushkarJ @k8s-ci-robot @k8s-triage-robot @aladewberry @dims @tabbysable @mrbobbytables @IanColdwater