Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating k8s-testgrid.appspot.com link to testgrid.k8s.io #7472

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Migrating k8s-testgrid.appspot.com link to testgrid.k8s.io #7472

merged 2 commits into from
Nov 4, 2023

Conversation

Ritikaa96
Copy link
Contributor

@Ritikaa96 Ritikaa96 commented Aug 17, 2023 •
edited
Loading

What this PR does / why we need it:
Fixes a bunch of broken links to testgrid dashboard.

Which issue(s) this PR fixes:
This is related to an umbrella issue and fixes a task of the same:
kubernetes/test-infra#30370

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/community-management labels Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added area/developer-guide Issues or PRs related to the developer guide committee/steering Denotes an issue or PR intended to be handled by the steering committee. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 17, 2023
@Ritikaa96
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 17, 2023
@letmerecall letmerecall mentioned this pull request Aug 17, 2023
Closed
40 tasks
mrbobbytables
mrbobbytables requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we consider anything in an archive folder for historical purposes only and they should not be updated.

The readmes, charters, and the e2e-tests doc are the only ones that should be updated 👍

@Ritikaa96
Copy link
Contributor Author

Noted . I'll revert the changes from archive folder.

@Ritikaa96 Ritikaa96 force-pushed the migrate-tesgrid-link branch from 3f59f2f to a947554 Compare October 10, 2023 08:40
@Ritikaa96
Copy link
Contributor Author

In general we consider anything in an archive folder for historical purposes only and they should not be updated.

The readmes, charters, and the e2e-tests doc are the only ones that should be updated 👍

Hi @mrbobbytables PTAL, i have reverted the changes from Archive folder

@Ritikaa96 Ritikaa96 closed this Oct 27, 2023
@Ritikaa96 Ritikaa96 reopened this Oct 27, 2023
@Ritikaa96
Copy link
Contributor Author

In general we consider anything in an archive folder for historical purposes only and they should not be updated.

The readmes, charters, and the e2e-tests doc are the only ones that should be updated 👍

Is this resolved now @mrbobbytables ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023
@mrbobbytables
Copy link
Member

Ah, sorry - missed the ping.
You can omit:

  • communication/meeting-notes-archive/*
  • sig-contributor-experience/meeting-notes-archive/2018-meeting-notes.md
  • sig-release/meeting-notes-archive/*

those are all archives of old meeting notes.

It does look like the sig-scalability doc needs to be rebased as well.

@Ritikaa96
Copy link
Contributor Author

Ah, sorry - missed the ping. You can omit:

  • communication/meeting-notes-archive/*
  • sig-contributor-experience/meeting-notes-archive/2018-meeting-notes.md
  • sig-release/meeting-notes-archive/*

those are all archives of old meeting notes.

It does look like the sig-scalability doc needs to be rebased as well.

Noted. I'll omit them and resolve the conflicts, thanks for the reviews :)

@Ritikaa96
Migrating k8s-testgrid.appspot.com link to testgrid.k8s.io
5f9d4e7 
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@Ritikaa96 Ritikaa96 force-pushed the migrate-tesgrid-link branch from a947554 to 71c4512 Compare November 2, 2023 11:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2023
@Ritikaa96 Ritikaa96 force-pushed the migrate-tesgrid-link branch from 71c4512 to 44ac927 Compare November 2, 2023 11:28
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2023
@Ritikaa96 Ritikaa96 force-pushed the migrate-tesgrid-link branch from 44ac927 to a84935d Compare November 2, 2023 11:31
@Ritikaa96
Reverting changes from archive folder
c6a5db1 
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@Ritikaa96 Ritikaa96 force-pushed the migrate-tesgrid-link branch from a84935d to c6a5db1 Compare November 2, 2023 11:49
@Ritikaa96
Copy link
Contributor Author

Hi @mrbobbytables PTAL!

@mrbobbytables mrbobbytables added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 4, 2023
@mrbobbytables
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, Ritikaa96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit eecb0e7 into kubernetes:master Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@jeefy jeefy Awaiting requested review from jeefy

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Node: code and documentation PRs
Archived in project
SIG Scheduling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ritikaa96 @mrbobbytables @k8s-ci-robot