Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete sig-etcd annual report for 2023 #7811

Merged
merged 1 commit into from
May 7, 2024
Merged

Complete sig-etcd annual report for 2023 #7811

merged 1 commit into from
May 7, 2024

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Apr 8, 2024

Fixes #7772

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2024
@k8s-ci-robot k8s-ci-robot added area/annual-reports Issues or PRs related to the annual reports sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2024
@jmhbnz
Copy link
Member Author

jmhbnz commented Apr 8, 2024

@wenjiaswe here is the first draft for our annual report, please have a look and let me know what you think 🙏🏻

@jmhbnz jmhbnz force-pushed the add-sig-etcd-report branch from 7ace8d0 to a18e775 Compare April 8, 2024 10:48
@wenjiaswe wenjiaswe mentioned this pull request Apr 26, 2024
Closed
wenjiaswe
wenjiaswe reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@wenjiaswe wenjiaswe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great to me, thank you very much James!

sig-etcd/annual-report-2023.md Show resolved Hide resolved
sig-etcd/annual-report-2023.md Show resolved Hide resolved
@jmhbnz
Complete sig-etcd annual report for 2023.
c4bc92f 
Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz jmhbnz force-pushed the add-sig-etcd-report branch from a18e775 to c4bc92f Compare May 3, 2024 21:07
@jmhbnz jmhbnz marked this pull request as ready for review May 3, 2024 21:11
@jmhbnz
Copy link
Member Author

jmhbnz commented May 3, 2024 •
edited
Loading

Marking ready for review.
/cc @mrbobbytables

@jmhbnz jmhbnz changed the title [WIP] Complete sig-etcd annual report for 2023 Complete sig-etcd annual report for 2023 May 3, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
mrbobbytables
mrbobbytables approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together :) Looks solid!
/lgtm
/hold

please release the hold if you're happy with it to merge 👍

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wenjiaswe
Copy link
Contributor

wenjiaswe commented May 7, 2024 •
edited
Loading

/lgtm

@jmhbnz
Copy link
Member Author

jmhbnz commented May 7, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit c11c027 into kubernetes:master May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@mrbobbytables mrbobbytables mrbobbytables approved these changes

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/annual-reports Issues or PRs related to the annual reports cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2023 Annual Report: SIG etcd
5 participants
@jmhbnz @k8s-ci-robot @wenjiaswe @serathius @mrbobbytables