Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: meet our contributors APAC China region #314

Merged
merged 8 commits into from
Aug 15, 2022
Merged

blog: meet our contributors APAC China region #314

merged 8 commits into from
Aug 15, 2022

Conversation

jayesh-srivastava
Copy link
Member

This PR adds the third blog post for China region, in the series of "Meet Our Contributors - APAC" blog series.

Reference issue: kubernetes/community#4469 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2022
jberkus
jberkus suggested changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@jberkus jberkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor editorial corrections.

content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
@jberkus
Copy link
Contributor

jberkus commented Jun 9, 2022

Also ... are you sure you want to publish this on 6/11, a Saturday?

@jayesh-srivastava
Copy link
Member Author

Also ... are you sure you want to publish this on 6/11, a Saturday?

Didn't think about this. Will change this to the 13th of June.

@jayesh-srivastava
Copy link
Member Author

@jberkus Can you review this now please?

@jberkus
Copy link
Contributor

jberkus commented Jun 11, 2022

Jayesh,

There's still some of the issues I called out in my first review.

@sftim
Copy link
Contributor

sftim commented Jun 13, 2022

If we want this mirrored onto https://k8s.io/blog/ (which is usual), please open a PR there once the final contents are agreed.

I suggest delaying a day or two to get that sorted. We can /hold this merge, get approvals, and then unhold it on publication day (cf #281)

@jayesh-srivastava
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2022
sftim
sftim reviewed Jun 13, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording suggestions

content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
@jayesh-srivastava
Copy link
Member Author

I suggest delaying a day or two to get that sorted. We can /hold this merge, get approvals, and then unhold it on publication day (cf #281)

@sftim I have updated the date too.

@jayesh-srivastava
Copy link
Member Author

@sftim @jberkus Are there more changes to be made? The date has to be changed tho.

@jberkus
Copy link
Contributor

jberkus commented Jun 22, 2022

Jayesh:

There's still to blocks of text that need correction, per above.

@jayesh-srivastava
Copy link
Member Author

@jberkus Have made the changes.

@jayesh-srivastava
Copy link
Member Author

jayesh-srivastava commented Jul 4, 2022 •
edited
Loading

/remove-hold

@jayesh-srivastava
Copy link
Member Author

@jberkus @sftim I guess this can be merged now. I changed the publish date to today's only. Also the hold label needs to be removed. I am not able to do it.

@Debanitrkl
Copy link
Member

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2022
Debanitrkl
Debanitrkl approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@Debanitrkl Debanitrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022
@jberkus
Copy link
Contributor

jberkus commented Jul 6, 2022

@Debanitrkl @kaslin @sftim we need a date for this, since it'll go on the Kubernetes blog as well.

@Debanitrkl
Copy link
Member

I guess next Monday i.e on 11th July let's schedule it.

@jayesh-srivastava
Copy link
Member Author

@Debanitrkl @kaslin @sftim @jberkus Have we decided on the date? Should I change it in the blog?

@sftim
Copy link
Contributor

sftim commented Jul 7, 2022

11th would be fine by me. Is there a PR against https://github.com/kubernetes/website already?

/hold
We can remove the hold on the publication date.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
@jayesh-srivastava
Copy link
Member Author

@sftim No there isn't a PR for k/website. I'll make it now as we have decided on the date. Also, I've updated the date for this PR.

@jayesh-srivastava
Copy link
Member Author

@sftim This is the PR against k/website. (kubernetes/website#34865)

@sftim sftim mentioned this pull request Jul 7, 2022
Merged
Babapool
Babapool reviewed Jul 7, 2022
View reviewed changes
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated
---


If you have any recommendations/suggestions for who we should interview next, please let us know in the #sig-contribex channel on the Kubernetes Slack. Your suggestions would be much appreciated. We're thrilled to have additional folks assisting us in reaching out to even more wonderful individuals of the community.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just a small nit from myside- adding a link to the #sig-contribex slack channel:

Suggested change
If you have any recommendations/suggestions for who we should interview next, please let us know in the #sig-contribex channel on the Kubernetes Slack. Your suggestions would be much appreciated. We're thrilled to have additional folks assisting us in reaching out to even more wonderful individuals of the community.
If you have any recommendations/suggestions for who we should interview next, please let us know in the [#sig-contribex channel](https://kubernetes.slack.com/messages/sig-contribex) on the Kubernetes Slack. Your suggestions would be much appreciated. We're thrilled to have additional folks assisting us in reaching out to even more wonderful individuals of the community.

@jayesh-srivastava
Copy link
Member Author

@sftim @Debanitrkl @jberkus Since there are more reviews on the PR against the k/website which haven't been finalized yet, I think we can hold this PR too until the 18th which is a Monday.

@sftim
Copy link
Contributor

sftim commented Aug 9, 2022

@jayesh-srivastava I'm a reviewer for both blogs; I'm fine with the idea of taking the text from here as the final version. It's nice to incorporate any feedback from SIG Docs' blog team, but not essential.

sftim
sftim reviewed Aug 9, 2022
View reviewed changes
content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated
---
layout: blog
title: "Meet Our Contributors - APAC (China region)"
date: 2022-07-11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we update this article (and its mirror) to publish on August 15th?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim Sure. Some suggestions on the k/website PR are still not resolved, so I was waiting for the SIG Docs members to comment on those but it's been weeks now. I'll make some minor changes and prepare the article and the mirror to get published on August 15th now.

@jayesh-srivastava
Copy link
Member Author

@sftim I've updated this article as well as the mirror (kubernetes/website#34865) to get published on August 15th. Can you please review them?

sftim
sftim reviewed Aug 14, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing to fix.

content/en/blog/2022/meet-our-contributors-APAC-China-region-03.md Outdated Show resolved Hide resolved
@jayesh-srivastava @sftim
remove canonical url
a670d68 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@sftim
Copy link
Contributor

sftim commented Aug 14, 2022

/label tide/merge-method-squash
/hold
until publication date - see #281

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 14, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Debanitrkl, jayesh-srivastava, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2022
@sftim
Copy link
Contributor

sftim commented Aug 15, 2022

/hold cancel

Ready to publish

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 16620bc into kubernetes:master Aug 15, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberkus jberkus jberkus requested changes

@sftim sftim sftim left review comments

@Babapool Babapool Babapool left review comments

@Debanitrkl Debanitrkl Debanitrkl approved these changes

@jeefy jeefy Awaiting requested review from jeefy

Assignees

@sftim sftim

@Debanitrkl Debanitrkl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Contribex Comms Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jayesh-srivastava @jberkus @sftim @Debanitrkl @k8s-ci-robot @Babapool