Introduce global settings #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maciaszczykm
commented
Oct 31, 2017
•
maciaszczykm
commented
- add settings manager
- add global settings endpoint
- add settings view
- add settings menu entry
- handle concurrent settings change error (dialog with save anyways and refresh options)
- merge settings during save to avoid any data loss
- fix tests
- add tests
- create service to retrieve specific settings values and use it across the app
- generate translations
- service refresh after settings save
- handle cluster name setting
- handle items per page setting
- remove bower leftovers
- fix caching problem
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Current progress:
|
|
Current progress:
|
k8s-ci-robot
added
size/XXL
maciaszczykm
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
It is ready for an initial review. I have to fix few things in tests/annotations etc. |
floreks
reviewed
Nov 8, 2017
src/app/backend/settings/manager.go
Outdated
| func (sm *SettingsManager) SaveGlobalSettings(client kubernetes.Interface, s *api.Settings) error { | ||
| cm, isDiff := sm.load(client) | ||
| if isDiff { | ||
| return errors.New("settings changed since last reload") |
There was a problem hiding this comment.
Use LocalizeError method here so we can localize it in frontend.
There was a problem hiding this comment.
It is not displayed to the user but used to display "save anyways" dialog.
There was a problem hiding this comment.
I will comment it in the code.
|
Overall LGTM. |
added 19 commits
November 8, 2017 11:12
Codecov Report
@@ Coverage Diff @@
## master #2532 +/- ##
==========================================
- Coverage 59.07% 58.93% -0.14%
==========================================
Files 598 607 +9
Lines 13092 13268 +176
==========================================
+ Hits 7734 7820 +86
- Misses 5148 5234 +86
- Partials 210 214 +4
Continue to review full report at Codecov.
|
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.